Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2384673002:
Remove non-quiescent sites from power.top_25 (Closed)
|
Created:
4 years, 2 months ago by ericrk Modified:
4 years, 2 months ago Reviewers:
petrcermak CC:
chromium-reviews, telemetry-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove non-quiescent sites from power.top_25
Certain sites in the top_25 pageset are non-quiescent, which makes them
non-suitable for the power metrics. We had already excluded one, but
two others were causing issues. Update the filter to remove these as
well.
BUG=550537
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/258b761b927b9d1665e9ecef58b78cdc92e24636
Cr-Commit-Position: refs/heads/master@{#422558}
Patch Set 1 #Patch Set 2 : whitespace fix #
Total comments: 4
Patch Set 3 : fixes #Messages
Total messages: 26 (15 generated)
Description was changed from ========== Remove non-quiescent sites from power.top_25 Certain sites in the top_25 pageset are non-quiescent, which makes them non-suitable for the power metrics. We had already excluded one, but two others were causing issues. Update the filter to remove these as well. BUG=550537 ========== to ========== Remove non-quiescent sites from power.top_25 Certain sites in the top_25 pageset are non-quiescent, which makes them non-suitable for the power metrics. We had already excluded one, but two others were causing issues. Update the filter to remove these as well. BUG=550537 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
ericrk@chromium.org changed reviewers: + petrcermak@chromium.org
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM with 2 comments. https://codereview.chromium.org/2384673002/diff/20001/tools/perf/benchmarks/p... File tools/perf/benchmarks/power.py (right): https://codereview.chromium.org/2384673002/diff/20001/tools/perf/benchmarks/p... tools/perf/benchmarks/power.py:161: 'techcrunch.com', nit: this should be indented only 2 spaces (-2) https://codereview.chromium.org/2384673002/diff/20001/tools/perf/benchmarks/p... tools/perf/benchmarks/power.py:173: test = power.QuiescentPower you don't need the 'test' and 'page_set' fields here (inherited)
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from petrcermak@chromium.org Link to the patchset: https://codereview.chromium.org/2384673002/#ps40001 (title: "fixes")
https://codereview.chromium.org/2384673002/diff/20001/tools/perf/benchmarks/p... File tools/perf/benchmarks/power.py (right): https://codereview.chromium.org/2384673002/diff/20001/tools/perf/benchmarks/p... tools/perf/benchmarks/power.py:161: 'techcrunch.com', On 2016/10/03 08:07:51, petrcermak wrote: > nit: this should be indented only 2 spaces (-2) Done. https://codereview.chromium.org/2384673002/diff/20001/tools/perf/benchmarks/p... tools/perf/benchmarks/power.py:173: test = power.QuiescentPower On 2016/10/03 08:07:51, petrcermak wrote: > you don't need the 'test' and 'page_set' fields here (inherited) Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by ericrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Remove non-quiescent sites from power.top_25 Certain sites in the top_25 pageset are non-quiescent, which makes them non-suitable for the power metrics. We had already excluded one, but two others were causing issues. Update the filter to remove these as well. BUG=550537 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Remove non-quiescent sites from power.top_25 Certain sites in the top_25 pageset are non-quiescent, which makes them non-suitable for the power metrics. We had already excluded one, but two others were causing issues. Update the filter to remove these as well. BUG=550537 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
On 2016/10/03 21:56:39, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build > URL) s5_perf_cq is super backed up (builds are taking >5hrs, there is a single buildslave), dropping it from the trybots list - nothing about this change is specific to one android perfbot vs another. Have contacted sheriff.
The CQ bit was checked by ericrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove non-quiescent sites from power.top_25 Certain sites in the top_25 pageset are non-quiescent, which makes them non-suitable for the power metrics. We had already excluded one, but two others were causing issues. Update the filter to remove these as well. BUG=550537 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Remove non-quiescent sites from power.top_25 Certain sites in the top_25 pageset are non-quiescent, which makes them non-suitable for the power metrics. We had already excluded one, but two others were causing issues. Update the filter to remove these as well. BUG=550537 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove non-quiescent sites from power.top_25 Certain sites in the top_25 pageset are non-quiescent, which makes them non-suitable for the power metrics. We had already excluded one, but two others were causing issues. Update the filter to remove these as well. BUG=550537 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Remove non-quiescent sites from power.top_25 Certain sites in the top_25 pageset are non-quiescent, which makes them non-suitable for the power metrics. We had already excluded one, but two others were causing issues. Update the filter to remove these as well. BUG=550537 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/258b761b927b9d1665e9ecef58b78cdc92e24636 Cr-Commit-Position: refs/heads/master@{#422558} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/258b761b927b9d1665e9ecef58b78cdc92e24636 Cr-Commit-Position: refs/heads/master@{#422558} |
