Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2384623003: [wasm] [asm.js] Track direct function indices and fixup. (Closed)

Created:
4 years, 2 months ago by bradnelson
Modified:
4 years, 2 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] [asm.js] Track direct function indices and fixup. Recent changes to the wasm format prevent you from knowing the function index of a direct call until you know how many imports you have (the index spaces have been merged). Asm.js validation can't know this until all callsites have been visited if you want to avoid materializing the entire AST / parsing twice. Instead, keep a list of fixups to perform for all direct callsites, then update these with the imports count added when emitting the module. BUG=v8:4203 R=aseemgarg@chromium.org,titzer@chromium.org Committed: https://crrev.com/cfed56c2c539fc2a103423169212999b1e7143c5 Cr-Commit-Position: refs/heads/master@{#39937}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -68 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 6 chunks +30 lines, -61 lines 0 comments Download
M src/wasm/wasm-module-builder.h View 3 chunks +8 lines, -0 lines 0 comments Download
M src/wasm/wasm-module-builder.cc View 1 2 7 chunks +23 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
bradnelson
4 years, 2 months ago (2016-09-30 23:03:04 UTC) #3
bradn
Ping?
4 years, 2 months ago (2016-10-03 17:30:59 UTC) #8
aseemgarg
lgtm
4 years, 2 months ago (2016-10-03 19:38:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384623003/40001
4 years, 2 months ago (2016-10-03 20:59:24 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-03 21:04:33 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:04:57 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cfed56c2c539fc2a103423169212999b1e7143c5
Cr-Commit-Position: refs/heads/master@{#39937}

Powered by Google App Engine
This is Rietveld 408576698