components/spellcheck/browser/spellcheck_message_filter_platform_android.cc - Issue 2384613002: [Android] Fix spellcheck JNI crash when a tab is closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/spellcheck/browser/spellcheck_message_filter_platform_android.cc

Issue 2384613002: [Android] Fix spellcheck JNI crash when a tab is closed. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/spellcheck/browser/spellcheck_message_filter_platform.h ('K') | « components/spellcheck/browser/spellcheck_message_filter_platform.h ('k') | components/spellcheck/browser/spellchecker_session_bridge_android.cc » ('j') | components/spellcheck/browser/spellchecker_session_bridge_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/spellcheck/browser/spellcheck_message_filter_platform_android.cc

diff --git a/components/spellcheck/browser/spellcheck_message_filter_platform_android.cc b/components/spellcheck/browser/spellcheck_message_filter_platform_android.cc

index 50a0e5a2d9b7b750ba7639e915a6a7847687b18c..0e25c864657bf5ce258f50d05dc01f18f075159b 100644

--- a/components/spellcheck/browser/spellcheck_message_filter_platform_android.cc

+++ b/components/spellcheck/browser/spellcheck_message_filter_platform_android.cc

@@ -91,3 +91,9 @@ void SpellCheckMessageFilterPlatform::OnToggleSpellCheck(

if (!enabled)

impl_->DisconnectSession();

}

+void SpellCheckMessageFilterPlatform::OnDestruct() const {

+ // Needs to be destroyed on the UI thread, to avoid race conditions

+ // on the java side during clean-up.

+ BrowserThread::DeleteOnUIThread::Destruct(this);