Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2384603002: [System Health] Fix disabling of media test cases in smoke tests. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run all system health stories used by system health benchmarks. 5 """Run all system health stories used by system health benchmarks.
6 6
7 Only memory benchmarks are used when running these stories to make the total 7 Only memory benchmarks are used when running these stories to make the total
8 cycle time manageable. Other system health benchmarks should be using the same 8 cycle time manageable. Other system health benchmarks should be using the same
9 stories as memory ones, only with fewer actions (no memory dumping). 9 stories as memory ones, only with fewer actions (no memory dumping).
10 """ 10 """
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:social:facebook', # pylint: disable=line-too-long 50 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:social:facebook', # pylint: disable=line-too-long
51 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:news:cnn', # pylint: disable=line-too-long 51 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:news:cnn', # pylint: disable=line-too-long
52 52
53 # Permenently disabled from smoke test for being long-running. 53 # Permenently disabled from smoke test for being long-running.
54 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.long_running:tools:gmail-foreground', # pylint: disable=line- too-long 54 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.long_running:tools:gmail-foreground', # pylint: disable=line- too-long
55 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.long_running:tools:gmail-background', # pylint: disable=line- too-long 55 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.long_running:tools:gmail-background', # pylint: disable=line- too-long
56 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.long_running:tools:gmail-foreground', # pylint: disable=line -too-long 56 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.long_running:tools:gmail-foreground', # pylint: disable=line -too-long
57 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.long_running:tools:gmail-background', # pylint: disable=line -too-long 57 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.long_running:tools:gmail-background', # pylint: disable=line -too-long
58 58
59 # Disable media tests in CQ. crbug.com/649392 59 # Disable media tests in CQ. crbug.com/649392
60 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.play:media:soundcloud' # pylint: disable=line-too-long 60 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.play:media:soundcloud', # pylint: disable=line-too-long
61 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.play:media:google_play_music' # pylint: disable=line-too-lon g 61 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.play:media:google_play_music', # pylint: disable=line-too-lo ng
62 }) 62 })
63 63
64 64
65 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test): 65 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test):
66 66
67 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. 67 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST.
68 # 68 #
69 # This smoke test dynamically tests all system health user stories. So 69 # This smoke test dynamically tests all system health user stories. So
70 # disabling it for one failing or flaky benchmark would disable a much 70 # disabling it for one failing or flaky benchmark would disable a much
71 # wider swath of coverage than is usally intended. Instead, if a test is 71 # wider swath of coverage than is usally intended. Instead, if a test is
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 # parsed during test time which happens after load_tests are called. 147 # parsed during test time which happens after load_tests are called.
148 # Since none of our system health benchmarks creates stories based on 148 # Since none of our system health benchmarks creates stories based on
149 # command line options, it should be ok to pass options=None to 149 # command line options, it should be ok to pass options=None to
150 # CreateStorySet. 150 # CreateStorySet.
151 for story_to_smoke_test in ( 151 for story_to_smoke_test in (
152 benchmark_class().CreateStorySet(options=None).stories): 152 benchmark_class().CreateStorySet(options=None).stories):
153 suite.addTest( 153 suite.addTest(
154 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) 154 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
155 155
156 return suite 156 return suite
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698