Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: device/vr/android/gvr/gvr_device_provider.cc

Issue 2384593002: Encode frame number in pixel data for pose sync (Closed)
Patch Set: bajones #10: restoreStateFromContext, skip pixel read for non-async mode Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/vr/android/gvr/gvr_device_provider.cc
diff --git a/device/vr/android/gvr/gvr_device_provider.cc b/device/vr/android/gvr/gvr_device_provider.cc
index 6bb73a04cc1ba7dcec4c662c4dffb3a94259250f..5c6c3476d639f9325292cbbc251d74473e429e5c 100644
--- a/device/vr/android/gvr/gvr_device_provider.cc
+++ b/device/vr/android/gvr/gvr_device_provider.cc
@@ -65,6 +65,7 @@ class GvrNonPresentingDelegate : public GvrDelegate {
float top,
float width,
float height) override {}
+ void SetGvrPoseForWebVr(gvr::Mat4f pose, uint32_t frameNumStarted) override{};
mthiesse 2016/10/04 21:19:16 Same comment about function signature applies here
mthiesse 2016/10/04 21:19:16 nit: space after override
klausw 2016/10/04 23:08:14 I can't do that. Presubmit insists on me running "
klausw 2016/10/04 23:08:14 renamed to pose_index.
dcheng 2016/10/04 23:19:06 There's a stray semi-colon, that's why clang-forma
klausw 2016/10/04 23:56:42 Ah, thanks for spotting it. Fixed.
gvr::GvrApi* gvr_api() override { return gvr_api_.get(); }

Powered by Google App Engine
This is Rietveld 408576698