Immediately set toolbar background color when not animating

Immediately set toolbar background color when not animating

BUG=651378
Committed: https://crrev.com/77f004bd0c4e3598680019f2d7a72bc2c0e21f95
Cr-Commit-Position: refs/heads/master@{#422271}

[mdjones, 2016-09-29 21:12:20]

mdjones@chromium.org changed reviewers:
+ tedchoc@chromium.org

[mdjones, 2016-09-29 21:12:20]

ptal

[Ted C, 2016-09-30 17:06:05]

lgtm

is this something we could right a test for?  would be good to start adding some
regression tests for this kind of stuff since it has so many edge cases

[mdjones, 2016-09-30 21:36:07]

On 2016/09/30 17:06:05, Ted C wrote:
> lgtm
> 
> is this something we could right a test for?  would be good to start adding
some
> regression tests for this kind of stuff since it has so many edge cases

The exact repro for the bug is tricky, but I built a test case for the root
cause. This will make the browser appear broken in the test.

[Ted C, 2016-09-30 23:08:28]

lgtm

https://codereview.chromium.org/2384583002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java
(right):

https://codereview.chromium.org/2384583002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java:152:
ThreadUtils.runOnUiThread(new Runnable() {
I think you want runOnUiThreadBlocking.  Otherwise the test could end before
your assert.

https://codereview.chromium.org/2384583002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java:158:
assertTrue(mToolbarDataProvider.getPrimaryColor()
assertEquals is probably better here.

[mdjones, 2016-09-30 23:18:27]

https://codereview.chromium.org/2384583002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java
(right):

https://codereview.chromium.org/2384583002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java:152:
ThreadUtils.runOnUiThread(new Runnable() {
On 2016/09/30 23:08:27, Ted C wrote:
> I think you want runOnUiThreadBlocking.  Otherwise the test could end before
> your assert.

Done.

https://codereview.chromium.org/2384583002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java:158:
assertTrue(mToolbarDataProvider.getPrimaryColor()
On 2016/09/30 23:08:28, Ted C wrote:
> assertEquals is probably better here.

Done.

[mdjones, 2016-09-30 23:18:37]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-09-30 23:18:37]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2384583002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-09-30 23:19:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 01:59:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-01 02:01:31]

Description was changed from

==========
Immediately set toolbar background color when not animating

BUG=651378
==========

to

==========
Immediately set toolbar background color when not animating

BUG=651378

Committed: https://crrev.com/77f004bd0c4e3598680019f2d7a72bc2c0e21f95
Cr-Commit-Position: refs/heads/master@{#422271}
==========

[commit-bot: I haz the power, 2016-10-01 02:01:31]

Patchset 3 (id:??) landed as
https://crrev.com/77f004bd0c4e3598680019f2d7a72bc2c0e21f95
Cr-Commit-Position: refs/heads/master@{#422271}