Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2384573002: Run update-test-expectations after making it less conservative. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
bokan
CC:
ojan, blink-reviews, chromium-reviews, Dirk Pranke, jeffcarp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run update-test-expectations after making it less conservative. The change http://crrev.com/2380173002 would make update-test-expectations delete lines as long as the test appears non-flaky on all configurations with existing builders, ignoring configurations with no existing builders. This CL is the result of running that script -- so for any lines deleted here, that script has found that in recent runs for all existing matching continuous builders, the test appears non-flaky, i.e. passing all recent runs. BUG=248938, 339597, 352405, 364250, 381730, 404597, 410949, 419696, 473718, 498539, 518915, 520169, 520180, 520183, 520187, 520191, 520612, 520614, 521084, 521086, 521090, 521093, 521094, 521099, 521107, 521855, 522645, 542541, 552532, 587593, 587779, 588103, 594595, 594672, 597572, 613510, 614197, 622672, 629711 Committed: https://crrev.com/c8c31351d42c9ed62418ac6fcab6acea74b094db Cr-Commit-Position: refs/heads/master@{#421954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -70 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 15 chunks +0 lines, -70 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
qyearsley
4 years, 2 months ago (2016-09-29 20:39:33 UTC) #4
bokan
lgtm!
4 years, 2 months ago (2016-09-29 21:56:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384573002/1
4 years, 2 months ago (2016-09-29 22:17:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 22:23:33 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c8c31351d42c9ed62418ac6fcab6acea74b094db Cr-Commit-Position: refs/heads/master@{#421954}
4 years, 2 months ago (2016-09-29 22:28:32 UTC) #13
ojan
4 years, 2 months ago (2016-09-30 10:40:54 UTC) #14
Message was sent while issue was closed.
<3

Powered by Google App Engine
This is Rietveld 408576698