Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2384553003: PPC: [heap] Switch to 500k pages (Closed)

Created:
4 years, 2 months ago by JaideepBajwa
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, JoranSiu, john.yan, michael_dawson
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [heap] Switch to 500k pages To keep it consistent with other platforms. R=mlippautz@chromium.org, ulan@chromium.org BUG= Committed: https://crrev.com/e5cba5df20e81f2dfd5065b2ccdeee2bd03fb8af Cr-Commit-Position: refs/heads/master@{#39954}

Patch Set 1 #

Patch Set 2 : reverted kMinimumCodeRangeSize initial value which was based of 4MB ppc page size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M src/base/build_config.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/globals.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 2 months ago (2016-09-30 14:25:42 UTC) #1
JaideepBajwa
PTAL, this fix is required for ppc native to build cleanly. Thank you.
4 years, 2 months ago (2016-10-03 21:28:07 UTC) #2
Michael Lippautz
On 2016/10/03 21:28:07, JaideepBajwa wrote: > PTAL, this fix is required for ppc native to ...
4 years, 2 months ago (2016-10-04 09:19:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384553003/20001
4 years, 2 months ago (2016-10-04 13:05:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 13:32:17 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 13:32:49 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5cba5df20e81f2dfd5065b2ccdeee2bd03fb8af
Cr-Commit-Position: refs/heads/master@{#39954}

Powered by Google App Engine
This is Rietveld 408576698