Disable link-time optimization for remoting PNaCl plugin in Debug mode

Disable link-time optimization for remoting PNaCl plugin in Debug mode

Optimization was enabled for the plugin to workaround an issue with
linking libyuv. But that issue has been fixed, so it's not longer
necessary to optimize debug builds.

This also works around PNaCl link-time optimization bug that was
breaking debug builds. That bug currently doesn't affect non-debug
builds (if it breaks release builds in the future it's also possible
to work it around by disabling optimization with per-function
optnone attribute).

BUG=650499
Committed: https://crrev.com/f1f0af26d41c5119403b0781d804f7860e237871
Cr-Commit-Position: refs/heads/master@{#421938}

[Sergey Ulanov, 2016-09-29 19:41:36]

Description was changed from

==========
Disable link-time optimization for remoting PNaCl plugin in Debug mode

Optimization was enabled for the plugin to workaround an issue with
linking libyuv. But that issue has been fixed, so it's not longer
necessary to optimize debug builds.

This also works around PNaCl link-time optimization bug that was
breaking debug builds. That bug currently doesn't affect non-debug
builds (if it breaks release builds in the future it's also possible
to work it around by disabling optimization with per-function
noopt attribute).

BUG=650499
==========

to

==========
Disable link-time optimization for remoting PNaCl plugin in Debug mode

Optimization was enabled for the plugin to workaround an issue with
linking libyuv. But that issue has been fixed, so it's not longer
necessary to optimize debug builds.

This also works around PNaCl link-time optimization bug that was
breaking debug builds. That bug currently doesn't affect non-debug
builds (if it breaks release builds in the future it's also possible
to work it around by disabling optimization with per-function
optnone attribute).

BUG=650499
==========

[Sergey Ulanov, 2016-09-29 19:43:11]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-09-29 20:26:16]

lgtm

[Sergey Ulanov, 2016-09-29 20:27:56]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-09-29 20:28:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 21:27:27]

Description was changed from

==========
Disable link-time optimization for remoting PNaCl plugin in Debug mode

Optimization was enabled for the plugin to workaround an issue with
linking libyuv. But that issue has been fixed, so it's not longer
necessary to optimize debug builds.

This also works around PNaCl link-time optimization bug that was
breaking debug builds. That bug currently doesn't affect non-debug
builds (if it breaks release builds in the future it's also possible
to work it around by disabling optimization with per-function
optnone attribute).

BUG=650499
==========

to

==========
Disable link-time optimization for remoting PNaCl plugin in Debug mode

Optimization was enabled for the plugin to workaround an issue with
linking libyuv. But that issue has been fixed, so it's not longer
necessary to optimize debug builds.

This also works around PNaCl link-time optimization bug that was
breaking debug builds. That bug currently doesn't affect non-debug
builds (if it breaks release builds in the future it's also possible
to work it around by disabling optimization with per-function
optnone attribute).

BUG=650499
==========

[commit-bot: I haz the power, 2016-09-29 21:27:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-29 21:29:28]

Description was changed from

==========
Disable link-time optimization for remoting PNaCl plugin in Debug mode

Optimization was enabled for the plugin to workaround an issue with
linking libyuv. But that issue has been fixed, so it's not longer
necessary to optimize debug builds.

This also works around PNaCl link-time optimization bug that was
breaking debug builds. That bug currently doesn't affect non-debug
builds (if it breaks release builds in the future it's also possible
to work it around by disabling optimization with per-function
optnone attribute).

BUG=650499
==========

to

==========
Disable link-time optimization for remoting PNaCl plugin in Debug mode

Optimization was enabled for the plugin to workaround an issue with
linking libyuv. But that issue has been fixed, so it's not longer
necessary to optimize debug builds.

This also works around PNaCl link-time optimization bug that was
breaking debug builds. That bug currently doesn't affect non-debug
builds (if it breaks release builds in the future it's also possible
to work it around by disabling optimization with per-function
optnone attribute).

BUG=650499

Committed: https://crrev.com/f1f0af26d41c5119403b0781d804f7860e237871
Cr-Commit-Position: refs/heads/master@{#421938}
==========

[commit-bot: I haz the power, 2016-09-29 21:29:29]

Patchset 1 (id:??) landed as
https://crrev.com/f1f0af26d41c5119403b0781d804f7860e237871
Cr-Commit-Position: refs/heads/master@{#421938}