Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3105)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_manager.cc

Issue 2384533004: Fix style nit and update variable naming for AddToHomescreenManager. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapps/add_to_homescreen_manager.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_manager.cc b/chrome/browser/android/webapps/add_to_homescreen_manager.cc
index d9d086c5fe886687a465216ea289273d6ea3aa07..8c6a9a3b1efe808bbecf090c3fca6ad15ef6eb8e 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_manager.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_manager.cc
@@ -70,10 +70,11 @@ void AddToHomescreenManager::AddShortcut(
}
void AddToHomescreenManager::Start(content::WebContents* web_contents) {
- bool check_installable = false;
+ // Check whether to check WebApk compatibility.
pkotwicz 2016/09/30 21:57:03 Nit: Remove the comment. The comment does not say
F 2016/10/03 14:04:02 Done. Thx
+ bool check_webapk_compatible = false;
if (ChromeWebApkHost::AreWebApkEnabled() &&
content::IsOriginSecure(web_contents->GetLastCommittedURL())) {
- check_installable = true;
+ check_webapk_compatible = true;
} else {
ShowDialog();
}
@@ -83,7 +84,7 @@ void AddToHomescreenManager::Start(content::WebContents* web_contents) {
ShortcutHelper::GetMinimumHomescreenIconSizeInDp(),
ShortcutHelper::GetIdealSplashImageSizeInDp(),
ShortcutHelper::GetMinimumSplashImageSizeInDp(),
- check_installable, this);
+ check_webapk_compatible, this);
}
AddToHomescreenManager::~AddToHomescreenManager() {
@@ -153,7 +154,7 @@ void AddToHomescreenManager::OnUserTitleAvailable(
void AddToHomescreenManager::OnDataAvailable(const ShortcutInfo& info,
const SkBitmap& icon) {
if (is_webapk_compatible_) {
- CreateInfoBarForWebAPK(info, icon);
+ CreateInfoBarForWebApk(info, icon);
return;
}
@@ -168,7 +169,7 @@ void AddToHomescreenManager::OnDataAvailable(const ShortcutInfo& info,
AddShortcut(info, icon);
}
-void AddToHomescreenManager::CreateInfoBarForWebAPK(const ShortcutInfo& info,
+void AddToHomescreenManager::CreateInfoBarForWebApk(const ShortcutInfo& info,
const SkBitmap& icon) {
banners::AppBannerInfoBarDelegateAndroid::Create(
data_fetcher_->web_contents(), nullptr, info.user_title,
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698