Fix style nit and update variable naming for AddToHomescreenManager.

Fix style nit and update variable naming for AddToHomescreenManager.

Committed: https://crrev.com/14731754a7fc9adb3fccbb84d0f5ee726a8d2127
Cr-Commit-Position: refs/heads/master@{#422661}

[F, 2016-09-30 21:36:33]

Description was changed from

==========
Fix style nit and update variable naming for add_to_homescreen_manager.

BUG=
==========

to

==========
Fix style nit and update variable naming for add_to_homescreen_manager.

BUG=
==========

[F, 2016-09-30 21:36:33]

zpeng@chromium.org changed reviewers:
+ dominickn@chromium.org, pkotwicz@chromium.org

[F, 2016-09-30 21:37:28]

Hi Dominick & Peter,

Can you please take a look? Thanks!

[pkotwicz, 2016-09-30 21:57:03]

LGTM

https://codereview.chromium.org/2384533004/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapps/add_to_homescreen_manager.cc (right):

https://codereview.chromium.org/2384533004/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapps/add_to_homescreen_manager.cc:73: // Check whether
to check WebApk compatibility.
Nit: Remove the comment. The comment does not say anything that is not obvious
from reading the code.

For big blocks of code, comments which describe "what the code does" are useful.
For short blocks of code, comments which describe "why the code does something"
are useful, but not comments which describe "what the code does"

[dominickn, 2016-09-30 23:21:02]

lgtm % Peter's suggestion.

Also, remove the empty BUG= line in the CL description, and change
add_to_homescreen_manager to AddToHomescreenManager in the title. :)

[F, 2016-10-03 13:59:29]

Patchset #2 (id:20001) has been deleted

[F, 2016-10-03 14:01:53]

Description was changed from

==========
Fix style nit and update variable naming for add_to_homescreen_manager.

BUG=
==========

to

==========
Fix style nit and update variable naming for add_to_homescreen_manager.
==========

[F, 2016-10-03 14:02:42]

Description was changed from

==========
Fix style nit and update variable naming for add_to_homescreen_manager.
==========

to

==========
Fix style nit and update variable naming for AddToHomeScreenManager.
==========

[F, 2016-10-03 14:03:12]

Description was changed from

==========
Fix style nit and update variable naming for AddToHomeScreenManager.
==========

to

==========
Fix style nit and update variable naming for AddToHomescreenManager.
==========

[F, 2016-10-03 14:04:02]

Hi Dominick & Peter, PTAL

https://codereview.chromium.org/2384533004/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapps/add_to_homescreen_manager.cc (right):

https://codereview.chromium.org/2384533004/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapps/add_to_homescreen_manager.cc:73: // Check whether
to check WebApk compatibility.
On 2016/09/30 21:57:03, pkotwicz wrote:
> Nit: Remove the comment. The comment does not say anything that is not obvious
> from reading the code.
> 
> For big blocks of code, comments which describe "what the code does" are
useful.
> For short blocks of code, comments which describe "why the code does
something"
> are useful, but not comments which describe "what the code does"

Done. Thx

[dominickn, 2016-10-03 23:24:10]

Still lgtm.

You generally don't need to ask for another look if you've got the lg - if we've
given it, it means we trust you to implement the comments given. The only real
reason to ask for another look is if you disagreed with the comment or it wasn't
clear what you should do.

[F, 2016-10-04 00:10:50]

The CQ bit was checked by zpeng@chromium.org

[F, 2016-10-04 00:10:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/2384533004/#ps40001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-10-04 00:11:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 01:38:32]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-04 01:40:56]

Description was changed from

==========
Fix style nit and update variable naming for AddToHomescreenManager.
==========

to

==========
Fix style nit and update variable naming for AddToHomescreenManager.

Committed: https://crrev.com/14731754a7fc9adb3fccbb84d0f5ee726a8d2127
Cr-Commit-Position: refs/heads/master@{#422661}
==========

[commit-bot: I haz the power, 2016-10-04 01:40:57]

Patchset 2 (id:??) landed as
https://crrev.com/14731754a7fc9adb3fccbb84d0f5ee726a8d2127
Cr-Commit-Position: refs/heads/master@{#422661}