[wasm] Implement WebAssembly.validate()

[wasm] Implement WebAssembly.validate()

R=bradnelson@chromium.org,mtrofin@chromium.org
BUG=chromium:575167
Committed: https://crrev.com/424cd4cf84b3354277b2ca5823c14354357a0980
Cr-Commit-Position: refs/heads/master@{#39885}

[titzer, 2016-09-29 14:40:23]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 14:40:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 15:22:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 15:22:37]

Dry run: This issue passed the CQ dry run.

[Mircea Trofin, 2016-09-29 16:47:49]

LGTM, with 1 comment

https://codereview.chromium.org/2384513002/diff/1/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2384513002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:1821: if (result.val) delete result.val;
if (result.val != nullptr) or even:

if (result.ok) {
  DCHECK_NOT_NULL(result.val);
  delete result.val;
}

[titzer, 2016-09-29 17:07:30]

On 2016/09/29 16:47:49, Mircea Trofin wrote:
> LGTM, with 1 comment
> 
> https://codereview.chromium.org/2384513002/diff/1/src/wasm/wasm-module.cc
> File src/wasm/wasm-module.cc (right):
> 
>
https://codereview.chromium.org/2384513002/diff/1/src/wasm/wasm-module.cc#new...
> src/wasm/wasm-module.cc:1821: if (result.val) delete result.val;
> if (result.val != nullptr) or even:
> 
> if (result.ok) {
>   DCHECK_NOT_NULL(result.val);
>   delete result.val;
> }

Done.

[titzer, 2016-09-29 17:08:58]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-09-29 17:08:59]

The patchset sent to the CQ was uploaded after l-g-t-m from mtrofin@chromium.org
Link to the patchset: https://codereview.chromium.org/2384513002/#ps20001
(title: "Address review comments.")

[commit-bot: I haz the power, 2016-09-29 17:09:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 18:02:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-29 18:03:08]

Description was changed from

==========
[wasm] Implement WebAssembly.validate()

R=bradnelson@chromium.org,mtrofin@chromium.org
BUG=chromium:575167
==========

to

==========
[wasm] Implement WebAssembly.validate()

R=bradnelson@chromium.org,mtrofin@chromium.org
BUG=chromium:575167

Committed: https://crrev.com/424cd4cf84b3354277b2ca5823c14354357a0980
Cr-Commit-Position: refs/heads/master@{#39885}
==========

[commit-bot: I haz the power, 2016-09-29 18:03:08]

Patchset 2 (id:??) landed as
https://crrev.com/424cd4cf84b3354277b2ca5823c14354357a0980
Cr-Commit-Position: refs/heads/master@{#39885}