Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 23845004: Revert 222192 "Turn on canvas_skia for OSX" (Closed)

Created:
7 years, 3 months ago by kkania
Modified:
7 years, 3 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 222192 "Turn on canvas_skia for OSX" > Turn on canvas_skia for OSX > > Re-submit of r221930, with fixed include path. > > TBR=asvitkine@chromium.org > BUG=151935 > > Review URL: https://chromiumcodereview.appspot.com/23454018 TBR=groby@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -80 lines) Patch
M trunk/src/build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + trunk/src/ui/gfx/canvas_mac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/ui/gfx/canvas_unittest_mac.mm View 1 chunk +0 lines, -79 lines 0 comments Download
M trunk/src/ui/ui.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/ui/ui_unittests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kkania
7 years, 3 months ago (2013-09-10 06:47:02 UTC) #1
kkania
Committed patchset #1 manually as r222202.
7 years, 3 months ago (2013-09-10 06:49:10 UTC) #2
Ken Kania
7 years, 3 months ago (2013-09-10 06:50:40 UTC) #3
Message was sent while issue was closed.
On 2013/09/10 06:49:10, kkania wrote:
> Committed patchset #1 manually as r222202.

broke mac dbg bots:
[ RUN      ] CanvasTestMac.StringSizeIdenticalForSkia
[2362:11267:0909/222923:2520150666242:FATAL:canvas_skia.cc(175)] Check failed:
*width >= 0 (-1 vs. 0)
0   libbase.dylib                       0x0138e56f
base::debug::StackTrace::StackTrace() + 63
1   libbase.dylib                       0x0138e50b
base::debug::StackTrace::StackTrace() + 43
2   libbase.dylib                       0x01415aac
logging::LogMessage::~LogMessage() + 76
3   libbase.dylib                       0x0141458b
logging::LogMessage::~LogMessage() + 43
4   libui.dylib                         0x01992452
gfx::Canvas::SizeStringInt(std::basic_string<unsigned short,
base::string16_char_traits, std::allocator<unsigned short> > const&,
gfx::FontList const&, int*, int*, int, int) + 274
5   ui_unittests                        0x002b0190
gfx::CanvasTestMac::CompareSizes(char const*) + 256
6   ui_unittests                        0x002afb8b
gfx::CanvasTestMac_StringSizeIdenticalForSkia_Test::TestBody() + 59
7   ui_unittests                        0x004ef371 void
testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,
void>(testing::Test*, void (testing::Test::*)(), char const*) + 145
8   ui_unittests                        0x004e063e void
testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
void>(testing::Test*, void (testing::Test::*)(), char const*) + 126
9   ui_unittests                        0x004d3e0e testing::Test::Run() + 254
10  ui_unittests                        0x004d48d7 testing::TestInfo::Run() +
263
11  ui_unittests                        0x004d51a9 testing::TestCase::Run() +
265
12  ui_unittests                        0x004da9a5
testing::internal::UnitTestImpl::RunAllTests() + 821
13  ui_unittests                        0x004eb2e1 bool
testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool>(testing::internal::UnitTestImpl*, bool
(testing::internal::UnitTestImpl::*)(), char const*) + 145
14  ui_unittests                        0x004e2fee bool
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool>(testing::internal::UnitTestImpl*, bool
(testing::internal::UnitTestImpl::*)(), char const*) + 126
15  ui_unittests                        0x004da634 testing::UnitTest::Run() +
148
16  ui_unittests                        0x00523b98 base::TestSuite::Run() + 248
17  ui_unittests                        0x004fae84
base::internal::RunnableAdapter<int
(base::TestSuite::*)()>::Run(base::TestSuite*) + 132
18  ui_unittests                        0x004fad94
base::internal::InvokeHelper<false, int, base::internal::RunnableAdapter<int
(base::TestSuite::*)()>, void
()(ui::test::UITestSuite*)>::MakeItSo(base::internal::RunnableAdapter<int
(base::TestSuite::*)()>, ui::test::UITestSuite*) + 68
19  ui_unittests                        0x004facd4 base::internal::Invoker<1,
base::internal::BindState<base::internal::RunnableAdapter<int
(base::TestSuite::*)()>, int ()(base::TestSuite*), void
()(base::internal::UnretainedWrapper<ui::test::UITestSuite>)>, int
()(base::TestSuite*)>::Run(base::internal::BindStateBase*) + 116
20  ui_unittests                        0x0052ba8c base::Callback<int
()()>::Run() const + 76
21  ui_unittests                        0x00526904 base::LaunchUnitTests(int,
char**, base::Callback<int ()()> const&) + 388
22  ui_unittests                        0x004fa336 main + 198
23  ui_unittests                        0x0007ab75 start + 53

Powered by Google App Engine
This is Rietveld 408576698