Issue 23845003: Cleaned up deopt reason messages a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23845003: Cleaned up deopt reason messages a bit. (Closed)

Created:
7 years, 3 months ago by Sven Panne

Modified:
7 years, 3 months ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cleaned up deopt reason messages a bit. They are now a bit more consistent, and they don't mention the name of a flag, which will go out of sync some day. ;-) R=machenbach@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16514

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed typo #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	src/code-stubs-hydrogen.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
	M	src/hydrogen.cc	View		5 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

lgtm with nit https://codereview.chromium.org/23845003/diff/1/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/23845003/diff/1/src/code-stubs-hydrogen.cc#newcode891 src/code-stubs-hydrogen.cc:891: Add<HDeoptimize>("Tracing elements transisions", Deoptimizer::EAGER); nit: transitions

7 years, 3 months ago (2013-09-04 07:21:35 UTC) #2

Sven Panne

7 years, 3 months ago (2013-09-04 07:27:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16514 (presubmit successful).

Expand Messages | Collapse Messages