Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2384483003: Revert of Explicit control in tools of ANGLE frontend and backend (Closed)

Created:
4 years, 2 months ago by bsalomon
Modified:
4 years, 2 months ago
Reviewers:
Brian Osman
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Explicit control in tools of ANGLE frontend and backend (patchset #6 id:90001 of https://codereview.chromium.org/2381033002/ ) Reason for revert: Broke bots Original issue's description: > Explicit control in tools of ANGLE frontend and backend > > Update the ANGLE test GL context, GrContextFactory, and config parsing to allow explicit control of ANGLE front/backend. > > This will allow us to explicitly test ES2 vs ES3 interfaces to ANGLE as well as D3D9, D3D11, and OpenGL backends. > > Also makes the angle api types valid in all builds (but will just fail when SK_ANGLE=1 or not on windows for the d3d backends). > > BUG=skia:5804 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381033002 > > Committed: https://skia.googlesource.com/skia/+/50094fb489543655df026be4e4f99e09e57a1f49 TBR=brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5804 Committed: https://skia.googlesource.com/skia/+/7c2213ba61c61ab76117019f95705639e2f01de8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -315 lines) Patch
M infra/bots/recipes/swarm_perf.py View 3 chunks +1 line, -5 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus5-GPU-Adreno330-arm-Debug-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus6-GPU-Adreno420-arm-Release-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus7-GPU-Tegra3-arm-Release-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Release-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN.json View 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-GN.json View 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 2 chunks +2 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-VisualBench.json View 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug.json View 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Release.json View 1 chunk +1 line, -0 lines 0 comments Download
D infra/bots/recipes/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-GTX960-x86_64-Debug-ANGLE.json View 1 chunk +0 lines, -130 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/big_issue_number.json View 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/recipe_with_gerrit_patch.json View 2 chunks +2 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.py View 1 chunk +0 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-GPU-GTX960-x86_64-Debug-ANGLE.json View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/TestConfigParsing.cpp View 10 chunks +43 lines, -26 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 5 chunks +70 lines, -64 lines 0 comments Download
M tools/gpu/GrContextFactory.h View 2 chunks +32 lines, -12 lines 0 comments Download
M tools/gpu/GrContextFactory.cpp View 1 chunk +7 lines, -18 lines 0 comments Download
M tools/gpu/gl/angle/GLTestContext_angle.h View 1 chunk +8 lines, -14 lines 0 comments Download
M tools/gpu/gl/angle/GLTestContext_angle.cpp View 8 chunks +59 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bsalomon
Created Revert of Explicit control in tools of ANGLE frontend and backend
4 years, 2 months ago (2016-09-29 17:07:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384483003/1
4 years, 2 months ago (2016-09-29 17:07:13 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 17:07:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7c2213ba61c61ab76117019f95705639e2f01de8

Powered by Google App Engine
This is Rietveld 408576698