Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2384483002: [wasm] Refactor handling of data segments in WasmModuleBuilder. (Closed)

Created:
4 years, 2 months ago by titzer
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Refactor handling of data segments in WasmModuleBuilder. R=bradnelson@chromium.org,aseemgarg@chromium.org,mstarzinger@chromium.org BUG= Committed: https://crrev.com/ab21fec6d3e3c36f8dfb81e64380f9a771b380e1 Cr-Commit-Position: refs/heads/master@{#39887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -50 lines) Patch
M src/wasm/wasm-module-builder.h View 3 chunks +20 lines, -21 lines 0 comments Download
M src/wasm/wasm-module-builder.cc View 5 chunks +17 lines, -27 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
titzer
4 years, 2 months ago (2016-09-29 13:51:26 UTC) #1
bradn
lgtm
4 years, 2 months ago (2016-09-29 18:11:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384483002/1
4 years, 2 months ago (2016-09-29 18:11:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 18:13:02 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 18:13:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab21fec6d3e3c36f8dfb81e64380f9a771b380e1
Cr-Commit-Position: refs/heads/master@{#39887}

Powered by Google App Engine
This is Rietveld 408576698