Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2384473002: [regexp] Port RegExpConstructResultStub to TurboFan (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Port RegExpConstructResultStub to TurboFan The old hydrogen stub (and runtime fallback) are still needed while they are used in regexp.js. These will go away once affected code has been ported. Drive-by-fix: Fixed typo in GetFixedA{a,}rrayAllocationSize. BUG=v8:5339 Committed: https://crrev.com/22881b41d9e4a13990ee660d4afbf9b8cb58e849 Cr-Commit-Position: refs/heads/master@{#39952}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add optimization TODO and avoid two Smi->IntPtr conversions #

Patch Set 4 : Rebase #

Patch Set 5 : Adapt to new constant accessor style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -11 lines) Patch
M src/builtins/builtins-regexp.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M src/code-stub-assembler.h View 1 2 3 4 3 chunks +13 lines, -3 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 3 4 2 chunks +45 lines, -1 line 0 comments Download
M src/code-stubs.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (18 generated)
jgruber
Local runs of my modified exec-only octane/regexp benchmark show roughly 10% improvement on this. Let's ...
4 years, 2 months ago (2016-09-30 08:00:47 UTC) #10
jgruber
On 2016/09/30 08:00:47, jgruber wrote: > Local runs of my modified exec-only octane/regexp benchmark show ...
4 years, 2 months ago (2016-09-30 08:29:16 UTC) #14
Benedikt Meurer
lgtm
4 years, 2 months ago (2016-09-30 08:29:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384473002/40001
4 years, 2 months ago (2016-10-04 11:30:10 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/5446) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-10-04 11:31:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384473002/80001
4 years, 2 months ago (2016-10-04 11:39:41 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-04 12:06:42 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 12:06:57 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/22881b41d9e4a13990ee660d4afbf9b8cb58e849
Cr-Commit-Position: refs/heads/master@{#39952}

Powered by Google App Engine
This is Rietveld 408576698