Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2384463003: Add fence support for TransferBuffers (Closed)

Created:
4 years, 2 months ago by jvanverth1
Modified:
4 years, 2 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add test code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -3 lines) Patch
M include/gpu/GrCaps.h View 2 chunks +4 lines, -0 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 1 chunk +5 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +5 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLTypes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrCaps.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +8 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +13 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLTestInterface.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLTestInterface.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkCaps.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 chunk +28 lines, -0 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jvanverth1
Sorry to make you review it again -- I had to upload it to Reitveld ...
4 years, 2 months ago (2016-09-29 20:16:33 UTC) #3
bsalomon
lgtm
4 years, 2 months ago (2016-09-30 13:39:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384463003/20001
4 years, 2 months ago (2016-09-30 15:21:13 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 15:39:05 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/84741b308496409f4ff662658167221fc6801bbe

Powered by Google App Engine
This is Rietveld 408576698