Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2384453002: [turbofan] Eliminate unnecessary hole to undefined conversion. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
epertoso, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Eliminate unnecessary hole to undefined conversion. Add simplified operator reduction rule that reduces CheckedTaggedSignedToInt32(ConvertTaggedHoleToUndefined(x)) to CheckedTaggedSignedToInt32(x) which avoids the unnecessary hole to undefined conversion, as the check operation will fail equally on either hole or undefined. BUG=v8:5267 R=jarin@chromium.org Committed: https://crrev.com/cb0de11d800ffb0aa6ca26b54e97fd0f8b93d558 Cr-Commit-Position: refs/heads/master@{#39863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/compiler/simplified-operator-reducer.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 2 months ago (2016-09-29 12:24:03 UTC) #1
epertoso
lgtm
4 years, 2 months ago (2016-09-29 12:31:18 UTC) #5
Jarin
lgtm
4 years, 2 months ago (2016-09-29 12:31:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384453002/1
4 years, 2 months ago (2016-09-29 12:32:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 12:51:51 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 12:52:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb0de11d800ffb0aa6ca26b54e97fd0f8b93d558
Cr-Commit-Position: refs/heads/master@{#39863}

Powered by Google App Engine
This is Rietveld 408576698