Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: chrome/browser/metrics/variations/variations_seed_store.h

Issue 238443008: Make VariationsService simulate received seeds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/field_trial.h ('k') | chrome/browser/metrics/variations/variations_seed_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/variations/variations_seed_store.h
===================================================================
--- chrome/browser/metrics/variations/variations_seed_store.h (revision 265923)
+++ chrome/browser/metrics/variations/variations_seed_store.h (working copy)
@@ -33,10 +33,13 @@
// Stores the given seed data (serialized protobuf data) to local state, along
// with a base64-encoded digital signature for seed and the date when it was
// fetched. The |seed_data| will be base64 encoded for storage. If the string
- // is invalid, the existing prefs are left as is and false is returned.
+ // is invalid, the existing prefs are left as is and false is returned. On
+ // success and if |parsed_seed| is not NULL, |parsed_seed| will be filled
+ // with the de-serialized protobuf decoded from |seed_data|.
jwd 2014/04/25 15:29:23 Can you add a sanity test that |seed_data| has the
Alexei Svitkine (slow) 2014/04/25 15:43:37 Done.
bool StoreSeedData(const std::string& seed_data,
const std::string& base64_seed_signature,
- const base::Time& date_fetched);
+ const base::Time& date_fetched,
+ VariationsSeed* parsed_seed);
// Updates |kVariationsSeedDate| and logs when previous date was from a
// different day.
« no previous file with comments | « base/metrics/field_trial.h ('k') | chrome/browser/metrics/variations/variations_seed_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698