Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: components/offline_pages/offline_page_test_store.h

Issue 2384423003: [Offline pages] Resetting offline page metadata store if initial load fails (Closed)
Patch Set: Rebased and comments addressed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_test_store.h
diff --git a/components/offline_pages/offline_page_test_store.h b/components/offline_pages/offline_page_test_store.h
index 7464bdd15e07d1e3077381cd13d131bf018c29cd..ef58e112bac2782ace3e721b6143a8955c0be7eb 100644
--- a/components/offline_pages/offline_page_test_store.h
+++ b/components/offline_pages/offline_page_test_store.h
@@ -28,6 +28,8 @@ class OfflinePageTestStore : public OfflinePageMetadataStore {
WRITE_FAILED,
LOAD_FAILED,
REMOVE_FAILED,
+ RESET_SUCCESS,
+ RESET_FAILED,
};
explicit OfflinePageTestStore(
@@ -36,7 +38,7 @@ class OfflinePageTestStore : public OfflinePageMetadataStore {
~OfflinePageTestStore() override;
// OfflinePageMetadataStore overrides:
- void GetOfflinePages(const LoadCallback& callback) override;
+ void GetOfflinePages(const GetOfflinePagesCallback& callback) override;
void AddOfflinePage(const OfflinePageItem& offline_page,
const AddCallback& callback) override;
void UpdateOfflinePages(const std::vector<OfflinePageItem>& pages,
@@ -58,11 +60,14 @@ class OfflinePageTestStore : public OfflinePageMetadataStore {
const OfflinePageItem& last_saved_page() const { return last_saved_page_; }
void set_test_scenario(TestScenario scenario) { scenario_ = scenario; };
+ bool reset_called() const { return reset_called_; }
private:
OfflinePageItem last_saved_page_;
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
TestScenario scenario_;
+ bool reset_called_;
+ StoreState store_state_;
std::map<int64_t, OfflinePageItem> offline_pages_;

Powered by Google App Engine
This is Rietveld 408576698