Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: components/offline_pages/offline_page_metadata_store_sql.h

Issue 2384423003: [Offline pages] Resetting offline page metadata store if initial load fails (Closed)
Patch Set: Rebased and comments addressed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_metadata_store_sql.h
diff --git a/components/offline_pages/offline_page_metadata_store_sql.h b/components/offline_pages/offline_page_metadata_store_sql.h
index c26cae8fb3e6653ee5f3224d2cda2cc55115607c..54bbe00925e431829351abad35aaac2de9c75b1d 100644
--- a/components/offline_pages/offline_page_metadata_store_sql.h
+++ b/components/offline_pages/offline_page_metadata_store_sql.h
@@ -58,7 +58,7 @@ class OfflinePageMetadataStoreSQL : public OfflinePageMetadataStore {
~OfflinePageMetadataStoreSQL() override;
// Implementation methods.
- void GetOfflinePages(const LoadCallback& callback) override;
+ void GetOfflinePages(const GetOfflinePagesCallback& callback) override;
void AddOfflinePage(const OfflinePageItem& offline_page,
const AddCallback& callback) override;
void UpdateOfflinePages(const std::vector<OfflinePageItem>& pages,
@@ -80,9 +80,7 @@ class OfflinePageMetadataStoreSQL : public OfflinePageMetadataStore {
void OnResetDone(const ResetCallback& callback, StoreState state);
// Helper function that checks whether a valid DB connection is present.
- // Returns true if valid connection is present, otherwise it returns false and
- // calls the provided callback as a shortcut.
- bool CheckDb(const base::Closure& callback);
+ bool CheckStoreState();
// Background thread where all SQL access should be run.
scoped_refptr<base::SequencedTaskRunner> background_task_runner_;

Powered by Google App Engine
This is Rietveld 408576698