tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 6b38741b1c42684cbc4efe6a3a8ca52982f8d5a9..d265549da6f9d6e5a0c2493df43f0ec8d16fcdb8 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -38625,6 +38625,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="OfflinePages.LoadStatus" enum="OfflinePagesLoadStatus">
+  <obsolete>
+    Deprecated 10/2016, and replaced by OfflinePages.StoreState.
+  </obsolete>
   <owner>jianli@chromium.org</owner>
   <summary>
     Status code of loading from the offline pages metadata store.
@@ -38798,6 +38801,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="OfflinePages.StoreState" enum="OfflinePagesStoreState">
+  <owner>fgorski@chromium.org</owner>
+  <summary>
+    Store state at the time of initial load or reset of offline page metadata
+    store.

[Mark P, 2016/10/12 16:06:31]

It feels a bit odd to me to mix these two interpretations.  I'd think two
separate histograms would be cleaner and cleaer.  Why did you do it this way?

[fgorski, 2016/10/12 20:44:09]

This histogram covers the state of the store. If the store reset fails at some
point I will not be retrying anymore and some invalid state persists. It is not
covering 2 separate operations, but the state of store.

Do you feel strongly I report on initialization and reset using independent
status UMAs?

[Mark P, 2016/10/12 22:12:15]

I don't feel strongly.  I think I can imagine cases when you might want to just
the, say, initial load case and not be able to get it, but you'd know better
than me.

If you want to keep on histogram, please briefly explain here what causes a
reset of the offline page metadata store.  (Is this an explicit action by the
user?  Happens periodically?  etc.)

+  </summary>
+</histogram>
+
 <histogram name="OfflinePages.TotalPageSize" units="MB">
   <owner>fgorski@chromium.org</owner>
   <owner>jianli@chromium.org</owner>
@@ -91361,6 +91372,14 @@ value.
   <int value="1" label="Offline"/>
 </enum>
 
+<enum name="OfflinePagesStoreState" type="int">
+  <int value="0" label="Not loaded"/>
+  <int value="1" label="Loaded"/>
+  <int value="2" label="Store load failed"/>
+  <int value="3" label="Store reset failed"/>
+  <int value="4" label="Store operation failed, after store loaded"/>
+</enum>
+
 <enum name="OfflineStatus" type="int">
   <obsolete>
     Deprecated 4/2015.