Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2384403006: Remove unnecessary statics (Closed)

Created:
4 years, 2 months ago by heimbuef
Modified:
4 years, 2 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unnecessary statics In an anonymous namespace, all methods are already treated like being static, so no need for these keywords. Committed: https://crrev.com/94c8170a889d35095c797fae6e3261aaf0db7ced Cr-Commit-Position: refs/heads/master@{#40032}

Patch Set 1 : Remove unnecessary statics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/runtime/runtime-regexp.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
heimbuef
PTAL
4 years, 2 months ago (2016-10-06 11:07:48 UTC) #3
ahaas
lgtm
4 years, 2 months ago (2016-10-06 11:34:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384403006/20001
4 years, 2 months ago (2016-10-06 11:46:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-06 12:14:23 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 12:14:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94c8170a889d35095c797fae6e3261aaf0db7ced
Cr-Commit-Position: refs/heads/master@{#40032}

Powered by Google App Engine
This is Rietveld 408576698