Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: components/sessions/content/content_serialized_navigation_driver.h

Issue 2384403005: Fix flaky test ContentSerializedNavigationBuilderTest.ToNavigationEntry (Closed)
Patch Set: Address feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sessions/content/content_serialized_navigation_driver.h
diff --git a/components/sessions/content/content_serialized_navigation_driver.h b/components/sessions/content/content_serialized_navigation_driver.h
index a471738f33930721bcfc8720ee7899f51e16b79a..8d1cfa1f573ef1e4b88a25c73305978335f411fb 100644
--- a/components/sessions/content/content_serialized_navigation_driver.h
+++ b/components/sessions/content/content_serialized_navigation_driver.h
@@ -61,6 +61,10 @@ class SESSIONS_EXPORT ContentSerializedNavigationDriver
private:
ContentSerializedNavigationDriver();
friend struct base::DefaultSingletonTraits<ContentSerializedNavigationDriver>;
sky 2016/10/07 15:35:25 Move all the friends before the constructor, newli
jianli 2016/10/12 21:38:00 Done.
+ friend class ContentSerializedNavigationBuilderTest;
+
+ // Removes all the registered extended info handlers. For testing only.
+ void RemoveAllExtendedInfoHandlersForTesting();
sky 2016/10/07 15:35:25 Can the test do extended_info_handler_map_.clear()
jianli 2016/10/12 21:38:00 Done.
ExtendedInfoHandlerMap extended_info_handler_map_;

Powered by Google App Engine
This is Rietveld 408576698