Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: DEPS

Issue 2384353002: Ready to enable MSan build for PDFium (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gitignore ('k') | tools/msan/blacklist.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: DEPS
diff --git a/DEPS b/DEPS
index fc94f4bcb84fc215c022c0163f1e264f95440acd..218c0c325bc60348efaa39e7480b51c16550e005 100644
--- a/DEPS
+++ b/DEPS
@@ -14,6 +14,7 @@ vars = {
'gmock_revision': '29763965ab52f24565299976b936d1265cb6a271',
'gtest_revision': '8245545b6dc9c4703e6496d1efd19e975ad2b038',
'icu_revision': '2341038bf72869a5683a893a2b319a48ffec7f62',
+ 'instrumented_lib_revision': '45f5814b1543e41ea0be54c771e3840ea52cca4a',
'pdfium_tests_revision': '06411790a46e6497e5293f921ea9aa9fb2615e41',
'skia_revision': '39f7a10a04a914384944d8bf62621144ac4eeaa3',
'tools_memory_revision': '427f10475e1a8d72424c29d00bf689122b738e5d',
@@ -44,6 +45,9 @@ deps = {
"third_party/icu":
Var('chromium_git') + "/chromium/deps/icu.git@" + Var('icu_revision'),
+ "third_party/instrumented_libraries":
+ Var('chromium_git') + "/chromium/src/third_party/instrumented_libraries.git@" + Var('instrumented_lib_revision'),
+
"third_party/skia":
Var('chromium_git') + '/skia.git' + '@' + Var('skia_revision'),
@@ -180,4 +184,12 @@ hooks = [
'pattern': '.',
'action': ['python', 'pdfium/build/vs_toolchain.py', 'update'],
},
+ {
+ # Pull sanitizer-instrumented third-party libraries if requested via
+ # GYP_DEFINES.
dsinclair 2016/10/04 13:10:27 Should we file a bug to get download_binaries upda
aizatsky 2016/10/04 18:12:58 Most likely. Direct integration with GN is better.
Wei Li 2016/10/06 22:41:02 ok, filed https://crbug.com/653712
+ 'name': 'instrumented_libraries',
+ 'pattern': '\\.sha1',
+ 'action': ['python', 'pdfium/third_party/instrumented_libraries/scripts/download_binaries.py'],
+ },
+
]
« no previous file with comments | « .gitignore ('k') | tools/msan/blacklist.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698