Ready to enable MSan build for PDFium

Ready to enable MSan build for PDFium

Add all the necessary files used for MSan build and run.

BUG=pdfium:1
Committed: https://pdfium.googlesource.com/pdfium/+/62f367348ff8ff1e64c6f52c1ee5f77c3a89edc1

[Wei Li, 2016-10-04 00:30:07]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 00:30:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 00:40:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 00:40:26]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-10-04 00:45:31]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-10-04 00:45:32]

pls review, thanks

[Lei Zhang, 2016-10-04 00:48:11]

thestig@chromium.org changed reviewers:
+ glider@chromium.org

[Lei Zhang, 2016-10-04 00:48:11]

+glider

[dsinclair, 2016-10-04 13:10:28]

https://codereview.chromium.org/2384353002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/2384353002/diff/1/DEPS#newcode189
DEPS:189: # GYP_DEFINES.
Should we file a bug to get download_binaries updated to not use GYP_DEFINES?

[Alexander Potapenko, 2016-10-04 14:43:33]

Description was changed from

==========
Ready to enable MSan build for PDFium

Add all the necessary files used for MSan build and run.

BUG=pdfium:1
==========

to

==========
Ready to enable MSan build for PDFium

Add all the necessary files used for MSan build and run.

BUG=pdfium:1
==========

[Alexander Potapenko, 2016-10-04 14:43:33]

glider@chromium.org changed reviewers:
+ aizatsky@chromium.org

[Alexander Potapenko, 2016-10-04 14:43:44]

On 2016/10/04 13:10:28, dsinclair wrote:
> https://codereview.chromium.org/2384353002/diff/1/DEPS
> File DEPS (right):
> 
> https://codereview.chromium.org/2384353002/diff/1/DEPS#newcode189
> DEPS:189: # GYP_DEFINES.
> Should we file a bug to get download_binaries updated to not use GYP_DEFINES?

+aizatsky

[aizatsky, 2016-10-04 18:12:59]

https://codereview.chromium.org/2384353002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/2384353002/diff/1/DEPS#newcode189
DEPS:189: # GYP_DEFINES.
On 2016/10/04 at 13:10:27, dsinclair wrote:
> Should we file a bug to get download_binaries updated to not use GYP_DEFINES?

Most likely. Direct integration with GN is better.

[Wei Li, 2016-10-06 22:41:02]

https://codereview.chromium.org/2384353002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/2384353002/diff/1/DEPS#newcode189
DEPS:189: # GYP_DEFINES.
On 2016/10/04 18:12:58, aizatsky wrote:
> On 2016/10/04 at 13:10:27, dsinclair wrote:
> > Should we file a bug to get download_binaries updated to not use
GYP_DEFINES?
> 
> Most likely. Direct integration with GN is better.

ok, filed https://crbug.com/653712

[dsinclair, 2016-10-11 14:12:02]

lgtm

[Wei Li, 2016-10-14 23:48:26]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-10-14 23:48:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2384353002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-14 23:48:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 23:59:43]

Description was changed from

==========
Ready to enable MSan build for PDFium

Add all the necessary files used for MSan build and run.

BUG=pdfium:1
==========

to

==========
Ready to enable MSan build for PDFium

Add all the necessary files used for MSan build and run.

BUG=pdfium:1

Committed:
https://pdfium.googlesource.com/pdfium/+/62f367348ff8ff1e64c6f52c1ee5f77c3a89...
==========

[commit-bot: I haz the power, 2016-10-14 23:59:44]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/62f367348ff8ff1e64c6f52c1ee5f77c3a89...