DevTools: improve DevTools file watcher to send added and removed paths

third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 16 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.Object}
  */
 WebInspector.IsolatedFileSystemManager = function()
 {
+    WebInspector.Object.call(this);

[dgozman, 2016/10/04 00:17:02]

Whoa!

+
     /** @type {!Map<string, !WebInspector.IsolatedFileSystem>} */
     this._fileSystems = new Map();
     /** @type {!Map<number, function(!Array.<string>)>} */
     this._callbacks = new Map();
     /** @type {!Map<number, !WebInspector.Progress>} */
     this._progresses = new Map();
 
     InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.FileSystemRemoved, this._onFileSystemRemoved, this);
     InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.FileSystemAdded, this._onFileSystemAdded, this);
     InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.FileSystemFilesChanged, this._onFileSystemFilesChanged, this);
@@ skipping 145 matching lines @@
         this._fileSystems.delete(fileSystemPath);
         isolatedFileSystem.fileSystemRemoved();
         this.dispatchEventToListeners(WebInspector.IsolatedFileSystemManager.Events.FileSystemRemoved, isolatedFileSystem);
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _onFileSystemFilesChanged: function(event)
     {
-        var embedderPaths = /** @type {!Array<string>} */ (event.data);
-        var paths = embedderPaths.map(embedderPath => WebInspector.IsolatedFileSystemManager.normalizePath(embedderPath));
+        var changedPaths = /** @type {!Array<string>} */ (event.data["changedPaths"]).map(WebInspector.IsolatedFileSystemManager.normalizePath);
+        var addedPaths = /** @type {!Array<string>} */ (event.data["addedPaths"]).map(WebInspector.IsolatedFileSystemManager.normalizePath);
+        var removedPaths = /** @type {!Array<string>} */ (event.data["removedPaths"]).map(WebInspector.IsolatedFileSystemManager.normalizePath);
+        var paths = changedPaths.concat(addedPaths, removedPaths);

[dgozman, 2016/10/04 00:17:02]

Let's use it in the same patch?

[lushnikov, 2016/10/04 01:04:19]

Reverted this.

         this.dispatchEventToListeners(WebInspector.IsolatedFileSystemManager.Events.FileSystemFilesChanged, paths);
     },
 
     /**
      * @return {!Array<!WebInspector.IsolatedFileSystem>}
      */
     fileSystems: function()
     {
         return this._fileSystems.valuesArray();
     },
@@ skipping 139 matching lines @@
         this._callbacks.delete(requestId);
     },
 
     __proto__: WebInspector.Object.prototype
 }
 
 /**
  * @type {!WebInspector.IsolatedFileSystemManager}
  */
 WebInspector.isolatedFileSystemManager;