DevTools: improve DevTools file watcher to send added and removed paths

third_party/WebKit/Source/devtools/front_end/devtools.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /* eslint-disable indent */
 (function(window) {
 
 // DevToolsAPI ----------------------------------------------------------------
 
 /**
@@ skipping 176 matching lines @@
     },
 
     /**
      * @param {!{fileSystemName: string, rootURL: string, fileSystemPath: string}} fileSystem
      */
     fileSystemAdded: function(fileSystem)
     {
         this._dispatchOnInspectorFrontendAPI("fileSystemAdded", ["", fileSystem]);
     },
 
-    fileSystemFilesChanged: function(path)
+    fileSystemFilesChanged: function(changedPaths, addedPaths, removedPaths)

[dgozman, 2016/10/04 00:17:02]

Let's add JSDoc.

[lushnikov, 2016/10/04 01:04:18]

Done.

     {
-        this._dispatchOnInspectorFrontendAPI("fileSystemFilesChanged", [path]);
+        this._dispatchOnInspectorFrontendAPI("fileSystemFilesChanged", [changedPaths, addedPaths, removedPaths]);

[dgozman, 2016/10/04 00:17:02]

I'd rename the method to fileSystemPathsChanged to avoid confusion with old one,
and add the following code to this place. Everything else should work with new
method name.

// Support for legacy (<M55) frontends.
var api = window["InspectorFrontendAPI"];
if (api["fileSystemPathsChanged"])
    api["fileSystemPathsChanged"].call(api, changedPaths, addedPaths,
removedPaths)
else
    api["fileSystemFilesChanged"].call(api, <concat all paths>);

[lushnikov, 2016/10/04 01:04:18]

Nice, thanks!

As per offline discussion, I've refrained from changing API for now altogether.

     },
 
     /**
      * @param {number} requestId
      * @param {string} fileSystemPath
      * @param {number} totalWork
      */
     indexingTotalWorkCalculated: function(requestId, fileSystemPath, totalWork)
     {
         this._dispatchOnInspectorFrontendAPI("indexingTotalWorkCalculated", [requestId, fileSystemPath, totalWork]);
@@ skipping 967 matching lines @@
 
 if (!DOMTokenList.prototype.__originalDOMTokenListToggle) {
     DOMTokenList.prototype.__originalDOMTokenListToggle = DOMTokenList.prototype.toggle;
     DOMTokenList.prototype.toggle = function(token, force)
     {
         if (arguments.length === 1)
             force = !this.contains(token);
         return this.__originalDOMTokenListToggle(token, !!force);
     }
 }