Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 2384333002: Revert of cc/blimp: Add a LayerTreeHostRemote implementation. (Closed)

Created:
4 years, 2 months ago by horo
Modified:
4 years, 2 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc/blimp: Add a LayerTreeHostRemote implementation. (patchset #16 id:300001 of https://codereview.chromium.org/2362073002/ ) Reason for revert: cc_unittests on Mac-10.9 failing on chromium.mac/Mac10.9 Tests (dbg) BUG=652502 BeginFrameArgsTest.Helpers (run #1): [ RUN ] BeginFrameArgsTest.Helpers ../../cc/output/begin_frame_args_unittest.cc:66: Failure Value of: ::testing::PrintToString(args1) Actual: "64-byte object <B6-66 E8-02 01-00 00-00 F6-73 E8-02 01-00 00-00 16-00 00-00 A9-7F 00-00 E1-9C BD-01 01-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 FF-FF FF-FF FF-FF FF-FF 01-00 00-00 01-7F 00-00>" Expected: std::string("BeginFrameArgs(NORMAL, 0, 0, -1us)") Which is: "BeginFrameArgs(NORMAL, 0, 0, -1us)" ../../cc/output/begin_frame_args_unittest.cc:68: Failure Value of: ::testing::PrintToString(args2) Actual: "64-byte object <B6-66 E8-02 01-00 00-00 F6-73 E8-02 01-00 00-00 1A-00 00-00 01-00 00-00 3B-9F BD-01 01-00 00-00 01-00 00-00 00-00 00-00 02-00 00-00 00-00 00-00 03-00 00-00 00-00 00-00 01-00 00-00 01-7F 00-00>" Expected: std::string("BeginFrameArgs(NORMAL, 1, 2, 3us)") Which is: "BeginFrameArgs(NORMAL, 1, 2, 3us)" [ FAILED ] BeginFrameArgsTest.Helpers (1 ms) Original issue's description: > cc/blimp: Add a LayerTreeHostRemote implementation. > > This sets up the framework for a LayerTreeHostRemote that implements > the LayerTreeHost API when the compositor is running across a network > boundary. > > This change only sets the framework for running/scheduling main frame > updates and pushing the serialized state using the > CompositorProtoStateSink. Subsequent patches will add state > serialization. > > BUG=648442 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225 > Cr-Commit-Position: refs/heads/master@{#422555} TBR=wez@chromium.org,dtrainor@chromium.org,danakj@chromium.org,khushalsagar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=648442 Committed: https://crrev.com/f3f23433d9db7b305ae57ae67a215477a5ffa162 Cr-Commit-Position: refs/heads/master@{#422603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1148 lines) Patch
M cc/BUILD.gn View 3 chunks +0 lines, -10 lines 0 comments Download
D cc/blimp/compositor_proto_state.h View 1 chunk +0 lines, -33 lines 0 comments Download
D cc/blimp/compositor_proto_state.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D cc/blimp/layer_tree_host_remote.h View 1 chunk +0 lines, -151 lines 0 comments Download
D cc/blimp/layer_tree_host_remote.cc View 1 chunk +0 lines, -415 lines 0 comments Download
D cc/blimp/layer_tree_host_remote_unittest.cc View 1 chunk +0 lines, -344 lines 0 comments Download
D cc/blimp/remote_compositor_bridge.h View 1 chunk +0 lines, -55 lines 0 comments Download
D cc/blimp/remote_compositor_bridge.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D cc/blimp/remote_compositor_bridge_client.h View 1 chunk +0 lines, -31 lines 0 comments Download
D cc/test/fake_remote_compositor_bridge.h View 1 chunk +0 lines, -40 lines 0 comments Download
D cc/test/fake_remote_compositor_bridge.cc View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
horo
Created Revert of cc/blimp: Add a LayerTreeHostRemote implementation.
4 years, 2 months ago (2016-10-03 23:42:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384333002/1
4 years, 2 months ago (2016-10-03 23:43:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 23:46:18 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 23:48:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3f23433d9db7b305ae57ae67a215477a5ffa162
Cr-Commit-Position: refs/heads/master@{#422603}

Powered by Google App Engine
This is Rietveld 408576698