Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 2384323003: Ensure that the web contents trying to access native VR Shell is the webcontents we created. (Closed)

Created:
4 years, 2 months ago by mthiesse
Modified:
4 years, 2 months ago
Reviewers:
bshe
CC:
chromium-reviews, asimjour1, cjgrant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that the web contents trying to access native VR Shell is the webcontents we created. BUG=641413 Committed: https://crrev.com/c663cf534f2053da69e9aa8cbc32bf3466c74d4d Cr-Commit-Position: refs/heads/master@{#422812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/browser/android/vr_shell/vr_shell.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mthiesse
PTAL
4 years, 2 months ago (2016-10-04 15:18:14 UTC) #2
bshe
On 2016/10/04 15:18:14, mthiesse wrote: > PTAL lgtm
4 years, 2 months ago (2016-10-04 15:26:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384323003/1
4 years, 2 months ago (2016-10-04 15:39:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 15:49:08 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 15:50:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c663cf534f2053da69e9aa8cbc32bf3466c74d4d
Cr-Commit-Position: refs/heads/master@{#422812}

Powered by Google App Engine
This is Rietveld 408576698