Metrics - Add actions/README.md

Metrics - Add actions/README.md

BUG=

Committed: https://crrev.com/b125d7bbfad217a15a6b872c56d02981fc43dce5
Cr-Commit-Position: refs/heads/master@{#423755}

[Mark P, 2016-10-03 23:08:38]

Description was changed from

==========
Metrics - Add actions/README.md

BUG=
==========

to

==========
Metrics - Add actions/README.md

BUG=
==========

[Mark P, 2016-10-03 23:08:38]

mpearson@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Mark P, 2016-10-03 23:09:02]

While I'm at it, I did this. :-)

Take a look sometime. :-)

thanks,
mark

[rkaplow, 2016-10-04 17:17:06]

rkaplow@chromium.org changed reviewers:
+ jwd@chromium.org

[rkaplow, 2016-10-04 17:17:07]

lgtm

LG, adding jesse since he's done the most analysis with user actions recently
and he might have some other guidelines in mind.

[Mark P, 2016-10-06 21:54:38]

Apparently Jesse isn't interested in commenting.  Shall I submit?

--mark

https://codereview.chromium.org/2384323002/diff/20001/tools/metrics/actions/R...
File tools/metrics/actions/README.md (right):

https://codereview.chromium.org/2384323002/diff/20001/tools/metrics/actions/R...
tools/metrics/actions/README.md:110: changes.  The owners should be added in the
original user action description.
Added this section, basically a copy from the histograms version except omitted
the clause about removing a histogram if it's no longer useful.  (Generally user
actions correspond to *actions* and as long as the action remains the user
action recording should remain.  Thus, I don't encourage users to remove user
actions even if they think they're no longer useful.)

[rkaplow, 2016-10-06 22:03:07]

lgtm

yup, sg to submit. re-read and found a couple more small things.

https://codereview.chromium.org/2384323002/diff/20001/base/metrics/user_metri...
File base/metrics/user_metrics.h (right):

https://codereview.chromium.org/2384323002/diff/20001/base/metrics/user_metri...
base/metrics/user_metrics.h:21: // tools/metrics/actions/README.md
btw I think we should consider linking to the git frontend so a developer can
easily see the information, eg.

https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/actio...

It seems more natural for referring someone to something.

https://codereview.chromium.org/2384323002/diff/20001/tools/metrics/actions/R...
File tools/metrics/actions/README.md (right):

https://codereview.chromium.org/2384323002/diff/20001/tools/metrics/actions/R...
tools/metrics/actions/README.md:7: histograms.
nit, maybe say enumerated histograms here

https://codereview.chromium.org/2384323002/diff/20001/tools/metrics/actions/R...
tools/metrics/actions/README.md:127: Deleting user action entries would be bad
if someone to accidentally reused your
nit, remove 'to'

https://codereview.chromium.org/2384323002/diff/20001/tools/metrics/actions/R...
tools/metrics/actions/README.md:128: old user action name and thereby corrupts
new data with whatever old data is
I think corrupted would be better here - or you can say "which therefore
corrupts..."

[Mark P, 2016-10-06 22:21:13]

https://codereview.chromium.org/2384323002/diff/20001/base/metrics/user_metri...
File base/metrics/user_metrics.h (right):

https://codereview.chromium.org/2384323002/diff/20001/base/metrics/user_metri...
base/metrics/user_metrics.h:21: // tools/metrics/actions/README.md
On 2016/10/06 22:03:07, rkaplow wrote:
> btw I think we should consider linking to the git frontend so a developer can
> easily see the information, eg.
> 
>
https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/actio...
> 
> It seems more natural for referring someone to something.

Done here and actions.xml.

Also did for the histograms.xml and histogram_macros.h (might as well do it
while I'm thinking about it).

https://codereview.chromium.org/2384323002/diff/20001/tools/metrics/actions/R...
File tools/metrics/actions/README.md (right):

https://codereview.chromium.org/2384323002/diff/20001/tools/metrics/actions/R...
tools/metrics/actions/README.md:7: histograms.
On 2016/10/06 22:03:07, rkaplow wrote:
> nit, maybe say enumerated histograms here

Sure; done.

https://codereview.chromium.org/2384323002/diff/20001/tools/metrics/actions/R...
tools/metrics/actions/README.md:127: Deleting user action entries would be bad
if someone to accidentally reused your
On 2016/10/06 22:03:07, rkaplow wrote:
> nit, remove 'to'

Done.

https://codereview.chromium.org/2384323002/diff/20001/tools/metrics/actions/R...
tools/metrics/actions/README.md:128: old user action name and thereby corrupts
new data with whatever old data is
On 2016/10/06 22:03:07, rkaplow wrote:
> I think corrupted would be better here - or you can say "which therefore
> corrupts..."

Done; chose the latter.

[Mark P, 2016-10-06 22:24:55]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2016-10-06 22:24:55]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2384323002/#ps40001
(title: "rob's comments")

[commit-bot: I haz the power, 2016-10-06 22:25:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 00:19:05]

Description was changed from

==========
Metrics - Add actions/README.md

BUG=
==========

to

==========
Metrics - Add actions/README.md

BUG=
==========

[commit-bot: I haz the power, 2016-10-07 00:19:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-07 00:22:08]

Description was changed from

==========
Metrics - Add actions/README.md

BUG=
==========

to

==========
Metrics - Add actions/README.md

BUG=

Committed: https://crrev.com/b125d7bbfad217a15a6b872c56d02981fc43dce5
Cr-Commit-Position: refs/heads/master@{#423755}
==========

[commit-bot: I haz the power, 2016-10-07 00:22:08]

Patchset 3 (id:??) landed as
https://crrev.com/b125d7bbfad217a15a6b872c56d02981fc43dce5
Cr-Commit-Position: refs/heads/master@{#423755}