Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2384303002: Revert of add cast for tostring (Closed)

Created:
4 years, 2 months ago by reed1
Modified:
4 years, 2 months ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of add cast for tostring (patchset #1 id:1 of https://codereview.chromium.org/2385353002/ ) Reason for revert: base CL has legacy skp bug, so have to revert it Original issue's description: > add cast for tostring to fix google3 > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2385353002 > > TBR=True > NOTRY=True > > Committed: https://skia.googlesource.com/skia/+/4cfd5af26e5fab1699cfa2ab40d49c24cededd72 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/418374c0d27280f3a1161601ae5fab28a76a0d3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
reed1
Created Revert of add cast for tostring
4 years, 2 months ago (2016-10-03 21:33:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384303002/1
4 years, 2 months ago (2016-10-03 21:33:44 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:33:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/418374c0d27280f3a1161601ae5fab28a76a0d3c

Powered by Google App Engine
This is Rietveld 408576698