Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2384293002: Use FileDescriptorWatcher in ProcessOutputWatcher (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
tbarzic
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FileDescriptorWatcher in ProcessOutputWatcher This allows ProcessOutputWatcher to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 Committed: https://crrev.com/0bd9f1a1ba8ea5e03b189246691de08846ab0f9b Cr-Commit-Position: refs/heads/master@{#422835}

Patch Set 1 #

Patch Set 2 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M chromeos/process_proxy/process_output_watcher.h View 3 chunks +7 lines, -8 lines 0 comments Download
M chromeos/process_proxy/process_output_watcher.cc View 1 1 chunk +7 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-04 15:00:26 UTC) #10
tbarzic
lgtm
4 years, 2 months ago (2016-10-04 16:37:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384293002/20001
4 years, 2 months ago (2016-10-04 17:07:47 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 17:13:48 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 17:16:33 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bd9f1a1ba8ea5e03b189246691de08846ab0f9b
Cr-Commit-Position: refs/heads/master@{#422835}

Powered by Google App Engine
This is Rietveld 408576698