Issue 2384273002: Use FileDescriptorWatcher in base::TestLauncher.

Issue 2384273002: Use FileDescriptorWatcher in base::TestLauncher. (Closed)

Created:
4 years, 2 months ago by fdoray

Modified:
4 years, 2 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, darin-cc_chromium.org, jam

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use FileDescriptorWatcher in base::TestLauncher. FileDescriptorWatcher is a new API that should be used instead of MessageLoopForIO::WatchFileDescriptor when possible. BUG=645114 Committed: https://crrev.com/c1e4fe167267b6238ee43d175aa8d594b99137ce Cr-Commit-Position: refs/heads/master@{#423264}

Patch Set 1 #

Patch Set 2 : fix build error #

Patch Set 3 : add nacl nonsfi #

Patch Set 4 : fix win_clang #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -27 lines)			Patch
M	base/test/launcher/test_launcher.cc	View	1	3 chunks	+11 lines, -27 lines	0 comments	Download
M	base/test/launcher/test_launcher_nacl_nonsfi.cc	View	1 2 3	2 chunks	+8 lines, -0 lines	0 comments	Download
M	base/test/launcher/unit_test_launcher.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	content/public/test/test_launcher.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 24 (19 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

fdoray

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

4 years, 2 months ago (2016-10-03 20:57:42 UTC) #1

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384273002/1

4 years, 2 months ago (2016-10-03 20:58:17 UTC) #2

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-03 21:06:50 UTC) #3

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/234911) chromeos_amd64-generic_chromium_compile_only_ng on ...

4 years, 2 months ago (2016-10-03 21:06:51 UTC) #4

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

fdoray

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

4 years, 2 months ago (2016-10-03 21:12:15 UTC) #5

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384273002/20001

4 years, 2 months ago (2016-10-03 21:13:06 UTC) #6

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

fdoray

Description was changed from ========== Use FileDescriptorWatcher in base::TestLauncher. This allows base::TestLauncher to be used ...

4 years, 2 months ago (2016-10-03 21:14:46 UTC) #7

Description was changed from

==========
Use FileDescriptorWatcher in base::TestLauncher.

This allows base::TestLauncher to be used from any thread that
instantiates a FileDescriptorWatcher (not just threads that run
a MessageLoopForIO). This will facilitate the migration of
BrowserThreads to base/task_scheduler.

BUG=645114
==========

to

==========
Use FileDescriptorWatcher in base::TestLauncher.

FileDescriptorWatcher is a new API that should be used
instead of MessageLoopForIO::WatchFileDescriptor
when possible.

BUG=645114
==========

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-03 22:11:28 UTC) #8

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/246200)

4 years, 2 months ago (2016-10-03 22:11:29 UTC) #9

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

fdoray

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

4 years, 2 months ago (2016-10-05 13:34:50 UTC) #10

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384273002/40001

4 years, 2 months ago (2016-10-05 13:35:08 UTC) #11

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

fdoray

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

4 years, 2 months ago (2016-10-05 14:56:51 UTC) #12

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384273002/60001

4 years, 2 months ago (2016-10-05 14:57:09 UTC) #13

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

fdoray

fdoray@chromium.org changed reviewers: + phajdan.jr@chromium.org

4 years, 2 months ago (2016-10-05 15:54:57 UTC) #14

fdoray@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

fdoray

PTAL

4 years, 2 months ago (2016-10-05 15:54:57 UTC) #15

PTAL

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-05 16:44:38 UTC) #16

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 2 months ago (2016-10-05 16:44:38 UTC) #17

Dry run: This issue passed the CQ dry run.

Paweł Hajdan Jr.

LGTM

4 years, 2 months ago (2016-10-05 19:44:10 UTC) #18

LGTM

fdoray

The CQ bit was checked by fdoray@chromium.org

4 years, 2 months ago (2016-10-05 19:51:12 UTC) #19

The CQ bit was checked by fdoray@chromium.org

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384273002/60001

4 years, 2 months ago (2016-10-05 19:51:45 UTC) #20

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

Description was changed from ========== Use FileDescriptorWatcher in base::TestLauncher. FileDescriptorWatcher is a new API that ...

4 years, 2 months ago (2016-10-05 19:59:33 UTC) #21

Message was sent while issue was closed.

Description was changed from

==========
Use FileDescriptorWatcher in base::TestLauncher.

FileDescriptorWatcher is a new API that should be used
instead of MessageLoopForIO::WatchFileDescriptor
when possible.

BUG=645114
==========

to

==========
Use FileDescriptorWatcher in base::TestLauncher.

FileDescriptorWatcher is a new API that should be used
instead of MessageLoopForIO::WatchFileDescriptor
when possible.

BUG=645114
==========

commit-bot: I haz the power

Committed patchset #4 (id:60001)

4 years, 2 months ago (2016-10-05 19:59:34 UTC) #22

Message was sent while issue was closed.

Committed patchset #4 (id:60001)

commit-bot: I haz the power

Description was changed from ========== Use FileDescriptorWatcher in base::TestLauncher. FileDescriptorWatcher is a new API that ...

4 years, 2 months ago (2016-10-05 20:03:44 UTC) #23

Message was sent while issue was closed.

Description was changed from

==========
Use FileDescriptorWatcher in base::TestLauncher.

FileDescriptorWatcher is a new API that should be used
instead of MessageLoopForIO::WatchFileDescriptor
when possible.

BUG=645114
==========

to

==========
Use FileDescriptorWatcher in base::TestLauncher.

FileDescriptorWatcher is a new API that should be used
instead of MessageLoopForIO::WatchFileDescriptor
when possible.

BUG=645114

Committed: https://crrev.com/c1e4fe167267b6238ee43d175aa8d594b99137ce
Cr-Commit-Position: refs/heads/master@{#423264}
==========

commit-bot: I haz the power

Patchset 4 (id:??) landed as https://crrev.com/c1e4fe167267b6238ee43d175aa8d594b99137ce Cr-Commit-Position: refs/heads/master@{#423264}

4 years, 2 months ago (2016-10-05 20:03:45 UTC) #24

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/c1e4fe167267b6238ee43d175aa8d594b99137ce
Cr-Commit-Position: refs/heads/master@{#423264}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages