Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2384263004: Namespace-qualify calls to logging::MakeCheckOpString (Closed)

Created:
4 years, 2 months ago by kwiberg-chromium
Modified:
4 years, 2 months ago
Reviewers:
danakj
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Namespace-qualify calls to logging::MakeCheckOpString Otherwise, argument-dependent lookup will (given that the proper set of headers are included at the same time) identify WebRTC's rtc::MakeCheckOpString as an alternative to logging::MakeCheckOpString if one of the function arguments are from the rtc:: namespace, making the call ambiguous. This was the reason why https://codereview.webrtc.org/2384693002 had to be reverted. Committed: https://crrev.com/1a928bccdd01937e89f6c89bca9ad4a8735f7542 Cr-Commit-Position: refs/heads/master@{#422905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/logging.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
kwiberg-chromium
PTAL. Or redirect to the right person, if I arbitrarily selected the wrong OWNER...
4 years, 2 months ago (2016-10-04 16:41:56 UTC) #4
danakj
LGTM
4 years, 2 months ago (2016-10-04 20:17:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384263004/1
4 years, 2 months ago (2016-10-04 20:17:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 20:25:04 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 20:29:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a928bccdd01937e89f6c89bca9ad4a8735f7542
Cr-Commit-Position: refs/heads/master@{#422905}

Powered by Google App Engine
This is Rietveld 408576698