Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2384213003: reflow comments in platform/heap (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in platform/heap BUG=563793 Committed: https://crrev.com/7d42a66f228745c4b437b77ab92cfef81a399465 Cr-Commit-Position: refs/heads/master@{#422560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -155 lines) Patch
M third_party/WebKit/Source/platform/heap/CallbackStack.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/GarbageCollected.h View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 4 chunks +16 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 5 chunks +17 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTerminatedArray.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 13 chunks +42 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Member.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Persistent.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentNode.h View 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentNode.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/SafePoint.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/SafePoint.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/SelfKeepAlive.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp View 4 chunks +16 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 4 chunks +22 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 4 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/TraceTraits.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.h View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Nico
4 years, 2 months ago (2016-10-03 18:00:50 UTC) #3
haraken
LGTM
4 years, 2 months ago (2016-10-03 22:10:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384213003/1
4 years, 2 months ago (2016-10-03 22:12:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 22:21:30 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 22:22:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d42a66f228745c4b437b77ab92cfef81a399465
Cr-Commit-Position: refs/heads/master@{#422560}

Powered by Google App Engine
This is Rietveld 408576698