components/user_prefs/tracked/tracked_preference_validation_delegate.h - Issue 2384213002: Send a TrackedPreference incident when registry pref validation fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/user_prefs/tracked/tracked_preference_validation_delegate.h

Issue 2384213002: Send a TrackedPreference incident when registry pref validation fails. (Closed)

Patch Set: Address comments on patch set 4 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc ('K') | « components/user_prefs/tracked/tracked_preference_helper.cc ('k') | components/user_prefs/tracked/tracked_split_preference.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/user_prefs/tracked/tracked_preference_validation_delegate.h

diff --git a/components/user_prefs/tracked/tracked_preference_validation_delegate.h b/components/user_prefs/tracked/tracked_preference_validation_delegate.h

index 8ea9c80a0a5104958da4e8697e173485b52dcdb2..d010df5aee35dd488fd42a02f40b9a21d7cc62fd 100644

--- a/components/user_prefs/tracked/tracked_preference_validation_delegate.h

+++ b/components/user_prefs/tracked/tracked_preference_validation_delegate.h

@@ -28,6 +28,7 @@ class TrackedPreferenceValidationDelegate {

const std::string& pref_path,

const base::Value* value,

PrefHashStoreTransaction::ValueState value_state,

+ PrefHashStoreTransaction::ValueState external_validation_value_state,

bool is_personal) = 0;

// Notifies observes of the result (|value_state|) of checking the split

@@ -37,7 +38,9 @@ class TrackedPreferenceValidationDelegate {

const std::string& pref_path,

const base::DictionaryValue* dict_value,

const std::vector<std::string>& invalid_keys,

+ const std::vector<std::string>& external_validation_invalid_keys,

PrefHashStoreTransaction::ValueState value_state,

+ PrefHashStoreTransaction::ValueState external_validation_value_state,

bool is_personal) = 0;

};