Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2760)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 23842002: Whitelisting exts and plugins from cross-site document blocking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Another bug is fixed in test cases. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index ef9c3fc04d9a306ee5b4af59a4784042814afd79..86c9f7b76feeffb51eba42d66bb2c78f1ff2bb80 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -1305,4 +1305,15 @@ bool ChromeContentRendererClient::ShouldReportDetailedMessageForSource(
return extensions::IsSourceFromAnExtension(source);
}
+bool ChromeContentRendererClient::ShouldEnableSiteIsolationPolicy() const {
+ // SiteIsolationPolicy is off by default. We would like to activate the
Charlie Reis 2013/09/03 22:59:17 nit: drop "the"
dsjang 2013/09/04 00:37:37 Done.
+ // cross-site document blocking (for UMA data collection) for normal renderer
+ // processes running an normal web page from the Internet. We only turn on
Charlie Reis 2013/09/03 22:59:17 nit: a normal
dsjang 2013/09/04 00:37:37 Done.
+ // SiteIsolationPolicy for a renderer process that does not have the extension
+ // flag on. Currently, this cannot be turned off for resource requests from
Charlie Reis 2013/09/03 22:59:17 No need to mention plugins here, since that's expl
dsjang 2013/09/04 00:37:37 Done.
+ // plugins since they request resources via their embedding renderer process.
+ CommandLine* command_line = CommandLine::ForCurrentProcess();
+ return !command_line->HasSwitch(switches::kExtensionProcess);
+}
+
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698