content/public/renderer/content_renderer_client.cc - Issue 23842002: Whitelisting exts and plugins from cross-site document blocking

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/renderer/content_renderer_client.cc

Issue 23842002: Whitelisting exts and plugins from cross-site document blocking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Exclude plugins from cross-site document data collection/blocking. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/renderer/content_renderer_client.h ('K') | « content/public/renderer/content_renderer_client.h ('k') | content/renderer/render_process_impl.cc » ('j') | content/renderer/render_process_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/public/renderer/content_renderer_client.h"	5 #include "content/public/renderer/content_renderer_client.h"

6	6

7 namespace content {	7 namespace content {

8	8

9 SkBitmap* ContentRendererClient::GetSadPluginBitmap() {	9 SkBitmap* ContentRendererClient::GetSadPluginBitmap() {

10 return NULL;	10 return NULL;

(...skipping 169 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
180	180

181 bool ContentRendererClient::AllowPepperMediaStreamAPI(const GURL& url) {	181 bool ContentRendererClient::AllowPepperMediaStreamAPI(const GURL& url) {

182 return false;	182 return false;

183 }	183 }

184	184

185 bool ContentRendererClient::ShouldReportDetailedMessageForSource(	185 bool ContentRendererClient::ShouldReportDetailedMessageForSource(

186 const base::string16& source) const {	186 const base::string16& source) const {

187 return false;	187 return false;

188 }	188 }

189	189

	190 bool ContentRendererClient::ShouldEnableSiteIsolationPolicy() const {

	191 return false;
	Charlie Reis 2013/09/03 20:22:10 I think we can return true here. Reasoning: this I think we can return true here. Reasoning: this is only called within renderer processes, and if any embedders of content don't have extensions, then it's fine for this to be enabled. We only need to make sure it's disabled when we know it's an extension. No need to change the phrasing elsewhere. dsjang 2013/09/03 22:31:30 Done. Show quoted text On 2013/09/03 20:22:10, creis wrote: > I think we can return true here. Reasoning: this is only called within renderer > processes, and if any embedders of content don't have extensions, then it's fine > for this to be enabled. We only need to make sure it's disabled when we know > it's an extension. > > No need to change the phrasing elsewhere. Done.
	192 }

	193

190 } // namespace content	194 } // namespace content

OLD	NEW