Whitelisting exts and plugins from cross-site document blocking

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
@@ skipping 1287 matching lines @@
   }
 #endif  // !defined(OS_ANDROID)
   return false;
 }
 
 bool ChromeContentRendererClient::ShouldReportDetailedMessageForSource(
     const base::string16& source) const {
   return extensions::IsSourceFromAnExtension(source);
 }
 
+bool ChromeContentRendererClient::ShouldEnableSiteIsolationPolicy() const {
+  // SiteIsolationPolicy is off by default. We would like to activate the
+  // cross-site document blocking (for UMA data collection) for normal renderer
+  // processes running an normal web page from the Internet. We only turn on
+  // SiteIsolationPolicy for a renderer process without having the extension

[Charlie Reis, 2013/09/03 20:22:10]

nit: without having -> that does not have

[dsjang, 2013/09/03 22:31:30]

Done.

+  // flag on. Currently, this cannot be turned off for resource requests from
+  // plugins since they request resources via their embedding renderer process.
+  CommandLine* command_line = CommandLine::ForCurrentProcess();
+  const std::string process_type =
+      command_line->GetSwitchValueASCII(switches::kProcessType);
+  // We only turn on SiteIsolationPolicy for a renderer process without having
+  // the extension flag on.

[Charlie Reis, 2013/09/03 20:22:10]

This comment is redundant with the one above.

[dsjang, 2013/09/03 22:31:30]

Done.

+  DCHECK(process_type == switches::kRendererProcess);

[Charlie Reis, 2013/09/03 20:22:10]

If this passes the try jobs, then I think we can remove the process_type check.

[dsjang, 2013/09/03 22:31:30]

Done.

+  return !command_line->HasSwitch(switches::kExtensionProcess);
+}
+
 }  // namespace chrome