Whitelisting exts and plugins from cross-site document blocking

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
@@ skipping 48 matching lines @@
 #include "chrome/renderer/safe_browsing/malware_dom_details.h"
 #include "chrome/renderer/safe_browsing/phishing_classifier_delegate.h"
 #include "chrome/renderer/searchbox/searchbox.h"
 #include "chrome/renderer/searchbox/searchbox_extension.h"
 #include "chrome/renderer/tts_dispatcher.h"
 #include "chrome/renderer/validation_message_agent.h"
 #include "components/autofill/content/renderer/autofill_agent.h"
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 #include "components/autofill/content/renderer/password_generation_manager.h"
 #include "components/visitedlink/renderer/visitedlink_slave.h"
+#include "content/child/site_isolation_policy.h"

[Charlie Reis, 2013/09/03 16:43:23]

Yeah, we can only include things from content/public outside the content module.

Usually, we call out to an interface on ContentRendererClient when we need
chrome/ code to help make a decision about things in content/.  We could
probably add a ContentRendererClient::ShouldEnableSiteIsolationPolicy() and call
it from somewhere in content/renderer.  You'd then put the code below into
ChromeContentRendererClient's implementation of the method.

[dsjang, 2013/09/03 19:13:11]

Done.

 #include "content/public/common/content_constants.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/render_view.h"
 #include "content/public/renderer/render_view_visitor.h"
 #include "extensions/common/constants.h"
 #include "grit/generated_resources.h"
 #include "grit/locale_settings.h"
 #include "grit/renderer_resources.h"
 #include "ipc/ipc_sync_channel.h"
 #include "net/base/net_errors.h"
@@ skipping 259 matching lines @@
 
   // chrome-extension: resources should bypass Content Security Policy checks
   // when included in protected resources.
   WebSecurityPolicy::registerURLSchemeAsBypassingContentSecurityPolicy(
       extension_scheme);
   WebSecurityPolicy::registerURLSchemeAsBypassingContentSecurityPolicy(
       extension_resource_scheme);
 
   extensions::ExtensionsClient::Set(
       extensions::ChromeExtensionsClient::GetInstance());
+
+  // SiteIsolationPolicy is off by default. We only activate the cross-site
+  // document blocking (for UMA data collection) for normal renderer processes
+  // running an normal web page.
+
+  const std::string process_type =
+      command_line->GetSwitchValueASCII(switches::kProcessType);
+
+  // We only turn on SiteIsolationPolicy for a renderer process without having
+  // the extension flag on.
+  content::SiteIsolationPolicy::SetPolicyActivationFlag(
+      process_type == switches::kRendererProcess &&

[Charlie Reis, 2013/09/03 16:43:23]

This check doesn't seem necessary.  I think we can only get here in renderer
processes (since it's in chrome/renderer).

[dsjang, 2013/09/03 19:13:11]

Done.

+      !command_line->HasSwitch(switches::kExtensionProcess));
 }
 
 void ChromeContentRendererClient::RenderViewCreated(
     content::RenderView* render_view) {
   ContentSettingsObserver* content_settings =
       new ContentSettingsObserver(render_view);
   if (chrome_observer_.get()) {
     content_settings->SetContentSettingRules(
         chrome_observer_->content_setting_rules());
   }
@@ skipping 940 matching lines @@
 #endif  // !defined(OS_ANDROID)
   return false;
 }
 
 bool ChromeContentRendererClient::ShouldReportDetailedMessageForSource(
     const base::string16& source) const {
   return GURL(source).SchemeIs(extensions::kExtensionScheme);
 }
 
 }  // namespace chrome