Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2384183002: [wasm] cleanup wasm-module.cc (Closed)

Created:
4 years, 2 months ago by Mircea Trofin
Modified:
4 years, 2 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] cleanup wasm-module.cc - Coalesced all anonymous namespaces into one, and moved it to the top of the file, to match elsewhere in the v8 codebase. - Deleted dead code. - Moved functions that turned out to be local to wasm-module.cc to the anonymous namespace. BUG= Committed: https://crrev.com/55478da28ea9f44c433e2b2c9840f841b423e519 Cr-Commit-Position: refs/heads/master@{#39936}

Patch Set 1 #

Patch Set 2 : [wasm] cleanup wasm-module.cc #

Patch Set 3 : [wasm] cleanup wasm-module.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -257 lines) Patch
M src/frames.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-wasm.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/wasm/wasm-module.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/wasm/wasm-module.cc View 7 chunks +218 lines, -247 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
Mircea Trofin
4 years, 2 months ago (2016-10-03 16:42:58 UTC) #5
bradnelson
Looks ok in principle. But seems to redden bots?
4 years, 2 months ago (2016-10-03 17:18:04 UTC) #12
bradnelson
lgtm
4 years, 2 months ago (2016-10-03 20:58:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384183002/40001
4 years, 2 months ago (2016-10-03 20:59:03 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-03 21:03:27 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:03:47 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/55478da28ea9f44c433e2b2c9840f841b423e519
Cr-Commit-Position: refs/heads/master@{#39936}

Powered by Google App Engine
This is Rietveld 408576698