Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2384173003: Replace 2 histograms with Variations.SeedFetchResponseOrErrorCode. (Closed)

Created:
4 years, 2 months ago by Alexei Svitkine (slow)
Modified:
4 years, 2 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace 2 histograms with Variations.SeedFetchResponseOrErrorCode. Combines Variations.SeedFetchResponseCode and Variations.FailedRequestErrorCode histograms. It's useful to have error codes and http response codes in one. BUG=652406 Committed: https://crrev.com/6e0a63921b29d06a00295a7147d828ad4ee9624a Cr-Commit-Position: refs/heads/master@{#422580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M components/variations/service/variations_service.cc View 2 chunks +8 lines, -11 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Alexei Svitkine (slow)
4 years, 2 months ago (2016-10-03 20:38:09 UTC) #4
rkaplow
lgtm
4 years, 2 months ago (2016-10-03 21:03:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384173003/1
4 years, 2 months ago (2016-10-03 21:19:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 22:57:38 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 23:00:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e0a63921b29d06a00295a7147d828ad4ee9624a
Cr-Commit-Position: refs/heads/master@{#422580}

Powered by Google App Engine
This is Rietveld 408576698