Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 2384163003: Use FileDescriptorWatcher in NativeMessageProcessHost. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FileDescriptorWatcher in NativeMessageProcessHost. This allows NativeMessageProcessHost to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 Committed: https://crrev.com/8be7e5011d52cc9f1dbd55359e4bf417a73a1f89 Cr-Commit-Position: refs/heads/master@{#422906}

Patch Set 1 #

Patch Set 2 : fix test error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M chrome/browser/extensions/api/messaging/native_message_process_host.h View 1 4 chunks +7 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.cc View 3 chunks +7 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-03 21:28:12 UTC) #10
Sergey Ulanov
lgtm
4 years, 2 months ago (2016-10-04 20:15:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384163003/20001
4 years, 2 months ago (2016-10-04 20:18:36 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 20:26:10 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 20:29:03 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8be7e5011d52cc9f1dbd55359e4bf417a73a1f89
Cr-Commit-Position: refs/heads/master@{#422906}

Powered by Google App Engine
This is Rietveld 408576698