Add a --no-zygote command line flag

Add a --no-zygote command line flag

This patch adds a --no-zygote command line flag which can be used to
completely disable the use of the zygote process. This is needed for
running Headless Chrome in environments where maintaining a forking
server such as the zygote is unnecessary and/or impractical.

Note that on Linux the sandbox needs the zygote to work, so --no-sandbox
must be used in conjunction with this new flag.

BUG=546953
Committed: https://crrev.com/1964e861d7adb9107e8ca525464ae6e7d8f4dc5d
Cr-Commit-Position: refs/heads/master@{#423152}

[Sami, 2016-10-03 14:55:01]

Description was changed from

==========
Add a --no-zygote command line flag

This patch adds a --no-zygote command line flag which can be used to
completely disable the use of the zygote process. This is needed for
running Headless Chrome in environments where maintaining a forking
server such as the zygote is unnecessary and/or impractical.

Note that on Linux the sandbox needs the zygote to work, so --no-sandbox
must be used in conjunction with this new flag.

BUG=546953
==========

to

==========
Add a --no-zygote command line flag

This patch adds a --no-zygote command line flag which can be used to
completely disable the use of the zygote process. This is needed for
running Headless Chrome in environments where maintaining a forking
server such as the zygote is unnecessary and/or impractical.

Note that on Linux the sandbox needs the zygote to work, so --no-sandbox
must be used in conjunction with this new flag.

BUG=546953
==========

[Sami, 2016-10-03 14:55:01]

skyostil@chromium.org changed reviewers:
+ creis@chromium.org

[Sami, 2016-10-03 14:55:26]

PTAL.

[Sami, 2016-10-03 14:55:31]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 14:55:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 15:40:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 15:40:20]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2016-10-03 18:46:09]

creis@chromium.org changed reviewers:
+ rickyz@chromium.org

[Charlie Reis, 2016-10-03 18:46:09]

creis@chromium.org changed required reviewers:
+ rickyz@chromium.org

[Charlie Reis, 2016-10-03 18:46:10]

content/ LGTM, but please get rickyz's approval just to be safe.

https://codereview.chromium.org/2384163002/diff/1/content/public/common/conte...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/2384163002/diff/1/content/public/common/conte...
content/public/common/content_switches.cc:670: // child processes will be forked
and exec'd directly.
Please mention the --no-sandbox dependency here.

[Sami, 2016-10-04 10:40:37]

On 2016/10/03 18:46:10, Charlie Reis wrote:
> content/ LGTM, but please get rickyz's approval just to be safe.

Thanks, will do.

https://codereview.chromium.org/2384163002/diff/1/content/public/common/conte...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/2384163002/diff/1/content/public/common/conte...
content/public/common/content_switches.cc:670: // child processes will be forked
and exec'd directly.
On 2016/10/03 18:46:10, Charlie Reis wrote:
> Please mention the --no-sandbox dependency here.

Good idea, done.

[rickyz (no longer on Chrome), 2016-10-04 20:00:32]

lgtm with nit - hopefully anyone running Chrome in this mode has some
alternative sandboxing mechanism - otherwise it'd be unsafe to use on untrusted
content.

https://codereview.chromium.org/2384163002/diff/20001/content/browser/browser...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2384163002/diff/20001/content/browser/browser...
content/browser/browser_main_loop.cc:211:
DCHECK(parsed_command_line.HasSwitch(switches::kNoSandbox));
Let's upgrade this to a CHECK with an error message.

[Sami, 2016-10-05 13:15:03]

On 2016/10/04 20:00:32, rickyz wrote:
> lgtm with nit - hopefully anyone running Chrome in this mode has some
> alternative sandboxing mechanism - otherwise it'd be unsafe to use on
untrusted
> content.

Definitely. Rest assured that is the case for the project we are working on.

[Sami, 2016-10-05 13:15:08]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-10-05 13:15:09]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
rickyz@chromium.org
Link to the patchset: https://codereview.chromium.org/2384163002/#ps60001
(title: "Better error message")

[Sami, 2016-10-05 13:15:16]

https://codereview.chromium.org/2384163002/diff/20001/content/browser/browser...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2384163002/diff/20001/content/browser/browser...
content/browser/browser_main_loop.cc:211:
DCHECK(parsed_command_line.HasSwitch(switches::kNoSandbox));
On 2016/10/04 20:00:32, rickyz wrote:
> Let's upgrade this to a CHECK with an error message.

Done.

[commit-bot: I haz the power, 2016-10-05 13:15:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 14:10:42]

Description was changed from

==========
Add a --no-zygote command line flag

This patch adds a --no-zygote command line flag which can be used to
completely disable the use of the zygote process. This is needed for
running Headless Chrome in environments where maintaining a forking
server such as the zygote is unnecessary and/or impractical.

Note that on Linux the sandbox needs the zygote to work, so --no-sandbox
must be used in conjunction with this new flag.

BUG=546953
==========

to

==========
Add a --no-zygote command line flag

This patch adds a --no-zygote command line flag which can be used to
completely disable the use of the zygote process. This is needed for
running Headless Chrome in environments where maintaining a forking
server such as the zygote is unnecessary and/or impractical.

Note that on Linux the sandbox needs the zygote to work, so --no-sandbox
must be used in conjunction with this new flag.

BUG=546953
==========

[commit-bot: I haz the power, 2016-10-05 14:10:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-05 14:12:25]

Description was changed from

==========
Add a --no-zygote command line flag

This patch adds a --no-zygote command line flag which can be used to
completely disable the use of the zygote process. This is needed for
running Headless Chrome in environments where maintaining a forking
server such as the zygote is unnecessary and/or impractical.

Note that on Linux the sandbox needs the zygote to work, so --no-sandbox
must be used in conjunction with this new flag.

BUG=546953
==========

to

==========
Add a --no-zygote command line flag

This patch adds a --no-zygote command line flag which can be used to
completely disable the use of the zygote process. This is needed for
running Headless Chrome in environments where maintaining a forking
server such as the zygote is unnecessary and/or impractical.

Note that on Linux the sandbox needs the zygote to work, so --no-sandbox
must be used in conjunction with this new flag.

BUG=546953

Committed: https://crrev.com/1964e861d7adb9107e8ca525464ae6e7d8f4dc5d
Cr-Commit-Position: refs/heads/master@{#423152}
==========

[commit-bot: I haz the power, 2016-10-05 14:12:26]

Patchset 4 (id:??) landed as
https://crrev.com/1964e861d7adb9107e8ca525464ae6e7d8f4dc5d
Cr-Commit-Position: refs/heads/master@{#423152}