Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: src/compiler/verifier.cc

Issue 2384113002: [turbofan] Osr value typing + dynamic type checks on entry. (Closed)
Patch Set: Fix liveness block Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 3b278993e6c1fdeb4e8a8527d87dd01e046e8cb7..a192eb2fe689c051d843648eb2e1945ac71ad8f3 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -375,6 +375,23 @@ void Verifier::Visitor::Check(Node* node) {
// Type is merged from other values in the graph and could be any.
CheckTypeIs(node, Type::Any());
break;
+ case IrOpcode::kOsrGuard:
+ // OSR values have a value and a control input.
+ CHECK_EQ(1, value_count);
+ CHECK_EQ(1, effect_count);
+ CHECK_EQ(1, control_count);
+ switch (OsrGuardTypeOf(node->op())) {
+ case OsrGuardType::kUninitialized:
+ CheckTypeIs(node, Type::None());
+ break;
+ case OsrGuardType::kSignedSmall:
+ CheckTypeIs(node, Type::SignedSmall());
+ break;
+ case OsrGuardType::kAny:
+ CheckTypeIs(node, Type::Any());
+ break;
+ }
+ break;
case IrOpcode::kProjection: {
// Projection has an input that produces enough values.
int index = static_cast<int>(ProjectionIndexOf(node->op()));
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698