Fix spacing issues on Ash shelf

Fix spacing issues on Ash shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

With these changes, showing system update icon is not necessary anymore
for some tests to pass. The hack is removed and the disabled test is
re-enabled (see https://crbug.com/619344 and https://crbug.com/625671).

BUG=634128, 619344, 625671
TEST=manual

Committed: https://crrev.com/888d1c0b366685696e5f4c73775575cc61bdab87
Cr-Commit-Position: refs/heads/master@{#433792}

[mohsen, 2016-10-03 18:33:02]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 18:34:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 19:03:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 19:03:10]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mohsen, 2016-10-03 20:10:24]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 20:10:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 20:38:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 20:38:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mohsen, 2016-10-06 20:09:38]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 20:10:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2016-10-06 20:16:37]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-10-06 20:44:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 20:44:20]

Dry run: Exceeded global retry quota

[mohsen, 2016-11-18 02:55:51]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 02:57:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 03:36:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 03:36:42]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mohsen, 2016-11-20 22:55:11]

Patchset #4 (id:80001) has been deleted

[mohsen, 2016-11-21 16:44:06]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 16:44:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2016-11-21 16:45:21]

Patchset #4 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-11-21 16:47:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mohsen, 2016-11-21 16:48:35]

The CQ bit was unchecked by mohsen@chromium.org

[mohsen, 2016-11-21 16:49:00]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 16:49:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2016-11-21 17:19:58]

Patchset #4 (id:120001) has been deleted

[commit-bot: I haz the power, 2016-11-21 17:21:48]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[mohsen, 2016-11-21 17:24:08]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 17:24:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2016-11-21 18:48:34]

Patchset #4 (id:140001) has been deleted

[mohsen, 2016-11-21 18:51:46]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 18:52:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2016-11-21 18:57:47]

Description was changed from

==========
Fix spacing issues on shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

BUG=634128
==========

to

==========
Fix spacing issues on shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

BUG=634128
TEST=manual
==========

[mohsen, 2016-11-21 19:09:05]

Description was changed from

==========
Fix spacing issues on shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

BUG=634128
TEST=manual
==========

to

==========
Fix spacing issues on shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

With these changes, showing system update icon is not necessary anymore
for some tests to pass. The hack is removed (see crbug.com/619344).

BUG=634128,619344
TEST=manual
==========

[commit-bot: I haz the power, 2016-11-21 19:19:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 19:19:08]

Dry run: This issue passed the CQ dry run.

[mohsen, 2016-11-21 20:12:38]

mohsen@chromium.org changed reviewers:
+ jamescook@chromium.org

[mohsen, 2016-11-21 20:12:39]

Please take a look...

(for details about state of shelf spacing and overflow, please see
https://docs.google.com/document/d/1R91NlX3Fw-TrxRmX-1KjIKYtLRtDxgR6UNsNJXMys...).

[James Cook, 2016-11-21 23:27:27]

LGTM!

(Can you put "ash" or "chromeos" in the CL title?)

https://codereview.chromium.org/2384103003/diff/160001/ash/common/test/test_s...
File ash/common/test/test_system_tray_delegate.h (left):

https://codereview.chromium.org/2384103003/diff/160001/ash/common/test/test_s...
ash/common/test/test_system_tray_delegate.h:24: static void
SetSystemUpdateRequired(bool required);
Hooray for getting rid of this!

[mohsen, 2016-11-22 00:13:00]

Description was changed from

==========
Fix spacing issues on shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

With these changes, showing system update icon is not necessary anymore
for some tests to pass. The hack is removed (see crbug.com/619344).

BUG=634128,619344
TEST=manual
==========

to

==========
Fix spacing issues on Ash shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

With these changes, showing system update icon is not necessary anymore
for some tests to pass. The hack is removed (see crbug.com/619344).

BUG=634128,619344
TEST=manual
==========

[mohsen, 2016-11-22 00:13:15]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2016-11-22 00:13:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2016-11-22 00:13:56]

The CQ bit was unchecked by mohsen@chromium.org

[mohsen, 2016-11-22 00:19:47]

Description was changed from

==========
Fix spacing issues on Ash shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

With these changes, showing system update icon is not necessary anymore
for some tests to pass. The hack is removed (see crbug.com/619344).

BUG=634128,619344
TEST=manual
==========

to

==========
Fix spacing issues on Ash shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

With these changes, showing system update icon is not necessary anymore
for some tests to pass. The hack is removed (see crbug.com/619344).

BUG=634128,619344,625671
TEST=manual
==========

[mohsen, 2016-11-22 00:21:35]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 00:22:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2016-11-22 00:23:17]

Description was changed from

==========
Fix spacing issues on Ash shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

With these changes, showing system update icon is not necessary anymore
for some tests to pass. The hack is removed (see crbug.com/619344).

BUG=634128,619344,625671
TEST=manual
==========

to

==========
Fix spacing issues on Ash shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

With these changes, showing system update icon is not necessary anymore
for some tests to pass. The hack is removed and the disabled test is
re-enabled (see https://crbug.com/619344).

BUG=634128,619344,625671
TEST=manual
==========

[mohsen, 2016-11-22 00:24:08]

Description was changed from

==========
Fix spacing issues on Ash shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

With these changes, showing system update icon is not necessary anymore
for some tests to pass. The hack is removed and the disabled test is
re-enabled (see https://crbug.com/619344).

BUG=634128,619344,625671
TEST=manual
==========

to

==========
Fix spacing issues on Ash shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

With these changes, showing system update icon is not necessary anymore
for some tests to pass. The hack is removed and the disabled test is
re-enabled (see https://crbug.com/619344 and https://crbug.com/625671).

BUG=634128,619344,625671
TEST=manual
==========

[commit-bot: I haz the power, 2016-11-22 00:56:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 00:56:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mohsen, 2016-11-22 04:47:51]

I had forgotten to re-enable the test that was using the now removed
SetSystemUpdateRequired() hack and was disabled because of flakiness. Re-enabled
now.

[mohsen, 2016-11-22 04:53:08]

The CQ bit was checked by mohsen@chromium.org

[mohsen, 2016-11-22 04:53:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2384103003/#ps180001
(title: "Re-enabled disabled test")

[commit-bot: I haz the power, 2016-11-22 04:53:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 04:56:54]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1479790388979830,
"parent_rev": "f7f1220bd11f1d6249e9457eda15b80522c2b479", "commit_rev":
"0f2a81b5c94e86d8d94f0b526dd3f0fa2822e96a"}

[commit-bot: I haz the power, 2016-11-22 04:57:19]

Committed patchset #5 (id:180001)

[commit-bot: I haz the power, 2016-11-22 04:59:24]

Description was changed from

==========
Fix spacing issues on Ash shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

With these changes, showing system update icon is not necessary anymore
for some tests to pass. The hack is removed and the disabled test is
re-enabled (see https://crbug.com/619344 and https://crbug.com/625671).

BUG=634128,619344,625671
TEST=manual
==========

to

==========
Fix spacing issues on Ash shelf

Following issues with shelf spacing are fixed:
 - Items move to overflow too soon: this happens because the space
   allocated to separate panel and non-panel items is equal to a button
   width. Changed it to a regular spacing between buttons;
 - Extra spacing at the end of shelf items, before tray items;
 - Discrepancy between ideal bounds calculated for items moved to the
   overflow shelf and the overflow button (they should be the same such
   that minimization animation for items in the overflow shelf ends at
   the overflow button or bubble for panel items in the overflow shelf
   points to the overflow button);
 - Possibility of panel app icons overlapping with overflow button;
 - Extra space before overflow button when it is the only item shown on
   the shelf (which happens when the launcher button is moved to the
   overflow shelf).

With these changes, showing system update icon is not necessary anymore
for some tests to pass. The hack is removed and the disabled test is
re-enabled (see https://crbug.com/619344 and https://crbug.com/625671).

BUG=634128,619344,625671
TEST=manual

Committed: https://crrev.com/888d1c0b366685696e5f4c73775575cc61bdab87
Cr-Commit-Position: refs/heads/master@{#433792}
==========

[commit-bot: I haz the power, 2016-11-22 04:59:25]

Patchset 5 (id:??) landed as
https://crrev.com/888d1c0b366685696e5f4c73775575cc61bdab87
Cr-Commit-Position: refs/heads/master@{#433792}