Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2384103002: Prune CreateVisibleSelectionDeprecated from DOMSelection (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune CreateVisibleSelectionDeprecated from DOMSelection BUG=651373 Committed: https://crrev.com/c333ca777eda0f33726c8e30f1a24600f63f70df Cr-Commit-Position: refs/heads/master@{#422376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 3 chunks +27 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-03 05:41:44 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-03 05:45:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384103002/1
4 years, 2 months ago (2016-10-03 06:10:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 06:14:56 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 06:16:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c333ca777eda0f33726c8e30f1a24600f63f70df
Cr-Commit-Position: refs/heads/master@{#422376}

Powered by Google App Engine
This is Rietveld 408576698