Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1469)

Unified Diff: content/common/frame_messages.h

Issue 23841002: Create a new RenderFrameHost per child frame when --site-per-process is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unittests. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
new file mode 100644
index 0000000000000000000000000000000000000000..670dd67cc9902dc825c10d31c3313d0c61c8608a
--- /dev/null
+++ b/content/common/frame_messages.h
@@ -0,0 +1,37 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// IPC messages for interacting with frames.
+// Multiply-included message file, hence no include guard.
+
+#include "content/common/content_export.h"
+#include "ipc/ipc_message_macros.h"
+
+#undef IPC_MESSAGE_EXPORT
+#define IPC_MESSAGE_EXPORT CONTENT_EXPORT
+
+#define IPC_MESSAGE_START FrameMsgStart
+
+// Sent by the renderer when a child frame is created in the render. The
Charlie Reis 2013/09/27 19:19:21 nit: in the renderer.
awong 2013/09/27 20:50:09 Done.
+// |parent_frame_id| and |frame_id| are NOT routing ids. They are
+// render-allocated identifiers used for tracking a frame's creation.
Charlie Reis 2013/09/27 19:19:21 renderer-allocated
awong 2013/09/27 20:50:09 Done.
+//
+// Each of these messages will have a corresponding FrameHostMsg_Detach message
+// sent when the frame is detached from the DOM.
+//
+// TOOD(ajwong): replace parent_render_frame_id and frame_id with just the
+// routing ids.
+IPC_SYNC_MESSAGE_CONTROL4_1(FrameHostMsg_CreateChildFrame,
+ int32 /* parent_render_frame_id */,
+ int64 /* parent_frame_id */,
+ int64 /* frame_id */,
+ std::string /* frame_name */,
+ int /* new_render_frame_id */)
+
+// Sent by the renderer to the parent frame when a child frame is detached
Charlie Reis 2013/09/27 19:19:21 nit: parent RenderFrameHost? (what's the parent?)
awong 2013/09/27 20:50:09 Done.
+// from the DOM.
+IPC_MESSAGE_ROUTED2(FrameHostMsg_Detach,
+ int64 /* parent_frame_id */,
+ int64 /* frame_id */)
+

Powered by Google App Engine
This is Rietveld 408576698